logical, txnapply: add in flight txn metrics#169672
Closed
DarrylWong wants to merge 2 commits into
Closed
Conversation
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
DarrylWong
force-pushed
the
ldr-txn-metrics
branch
6 times, most recently
from
f24d6dc to
2429994
Compare
DarrylWong
changed the title
DarrylWong
changed the title
DarrylWong
force-pushed
the
ldr-txn-metrics
branch
from
2429994 to
4caefa5
Compare
Contributor
Author
|
I'll have a followup PR to start wiring up some of the existing metrics, but these are ones I wanted for constraint testing to validate that we are generating sufficient dependencies: 
|
DarrylWong
force-pushed
the
ldr-txn-metrics
branch
from
4caefa5 to
64896d1
Compare
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
DarrylWong
force-pushed
the
ldr-txn-metrics
branch
from
64896d1 to
f021943
Compare
DarrylWong
force-pushed
the
ldr-txn-metrics
branch
from
f021943 to
23d1fd3
Compare
We want to start adding metrics to ldr txn mode, including the existing metrics. Txn mode is implemented as individual sub systems which will cause a dependency cycle if we attempt to import the original logical package. This change extracts the existing metrics struct to its own package. Release note: None
This change adds metrics to see in flight transactions in the applier pipeline. The number is broken down into blocked and ready txns. The former represents the number of txns that are blocked on either another txn or the event horizon. The latter represents the number of txns that are ready to be commited but haven't yet, i.e. on the ready buffer. Both gauges live on the parent metrics.Metrics struct as TxnApplierBlockedTxns and TxnApplierReadyTxns. The applier takes a *metrics.Metrics pointer at construction and updates the gauges directly. Release note: None
DarrylWong
force-pushed
the
ldr-txn-metrics
branch
from
23d1fd3 to
3918407
Compare
Contributor
Author
|
There is review happening in #171191, closing this one out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds metrics to see in flight transactions in the applier pipeline. The number is broken down into blocked and ready txns.
The former represents the number of txns that are blocked on either another txn or the event horizon. The latter represents the number of txns that are ready to be commited but haven't yet, i.e. on the ready buffer.
Fixes: None
Release note: None
Epic: https://cockroachlabs.atlassian.net/browse/CRDB-61283