roachtest/operations: add hold-connection operation#171302
Open
Dev-Kyle wants to merge 1 commit into
Open
Conversation
Dev-Kyle
requested review from
cpj2195 and
williamchoe3
and removed request for
a team
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
cockroach-teamcity
added
the
X-perf-gain
The hold-connection operation opens a single SQL session against the cluster and holds it open for an extended duration (30 days), periodically running a small rotation of distinct queries to keep the session alive on the server. The operation pins one underlying connection via pool.Conn(ctx) rather than relying on the *gosql.DB pool, ensuring the held session is the same physical connection for its entire lifetime. A keepalive ticker (5m) sends queries with varied fingerprints so the session accumulates cache state over time; a separate heartbeat ticker (1h) emits an operator-visible status line with remaining duration and queries executed so the long run is observable rather than silent. The 30-day duration is intentionally longer than any existing operation timeout in this package (the prior maximum was 96h on backup_restore). Reviewers should flag any DRT scheduler concerns with an operation that holds a slot for this long. Resolves: cockroachdb#122155 Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new DRT operation,
hold-connection, that opens a single SQL session and keeps it alive for 30 days, periodically running queries with varied fingerprints. The intent is to exercise long-lived session state under steady-state DRT load.The op is a small piece of orchestration: pin a single physical connection via
pool.Conn(ctx), run a keepAlive query every 5 min from a 7-entry rotation, and emit a heartbeat status line every hour so the long run is observable rather than silent.Notes for reviewers
pkg/cmd/roachtest/operations/(the prior max is 96h onbackup_restore). Please flag any DRT scheduler concerns with an op that holds a slot for this long.Resolves: #122155
Epic: none