mongo-c-driver: declare valid CMake range - #30788
Open
Dahlgren wants to merge 1 commit into
Open
Conversation
- <2.4.0 has broken TRY_COMPILE in src/libmongoc/CMakeLists.txt, failing in CMake 4.4+ - mongodb/mongo-c-driver@ea1b547 - <1.30.3/<2.1.0 has CMP0042 OLD in src/libbson/CMakeLists.txt, removed in CMake 4+ - mongodb/mongo-c-driver@2344038 - mongodb/mongo-c-driver@c60f45f - <1.25 has cmake_minimum_required (VERSION 3.1) in src/libbson/CMakeLists.txt, rejected in CMake 4+ - mongodb/mongo-c-driver@3c7951b#diff-71a4c7cf57df62b3b3d8bb547bcf79c5fafb5accb4a6608d696ccdf43e17ad6a
Contributor
|
Does defining Clipping the version range of CMake to <4 would prevent usage with Visual Studio 2026. I'd say we would only do this if the build script truly does not work with CMake <4 even with the policy workaround. |
Contributor
Author
It only fixes the last issue with |
Contributor
|
I'm a bit confused. What version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: mongo-c-driver
Motivation
It's not possible to compile mongo-c-driver recipe when newer versions of CMake are on system path, the recipe doesn't declare any CMake range
Details
Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!