libavrocpp: use archive.apache.org for 1.12.1 sources - #30802
Open
michalkas wants to merge 1 commit into
Open
Conversation
The 1.12.1 source archive was removed from dlcdn.apache.org, which only mirrors current releases, so the download failed. Point at the permanent Apache archive instead; the sha256 is unchanged. Resolves conan-io#30783
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: libavrocpp/1.12.1
Motivation
libavrocpp/1.12.1can no longer be installed at all: its source archive 404s.dlcdn.apache.orgis Apache's CDN for current releases only — once a version issuperseded, the tarball is removed. 1.12.1 has been superseded by 1.12.2, so the
URL in
conandata.ymlis now dead:fixes #30783
Fix bug as reported in #30783 (comment)
Details
Repointed the 1.12.1 source URL from
dlcdn.apache.orgtoarchive.apache.org,which permanently retains all past Apache releases. The artifact is byte-identical
—
sha256is unchanged, which the build verifies.archive.apache.orgis already the established convention for Apache sources.Not a duplicate of #30781, but related. That PR replaces 1.12.1 with 1.12.2.
Worth flagging for reviewers: bumping the version does not by itself fix the
build, because
lang/c++/include/avro/Exception.hhis identical inrelease-1.12.1andrelease-1.12.2— both callfmt::formatwhile includingonly
<fmt/core.h>. Since fmt 12.2.0,fmt/core.hno longer declaresfmt::format, so both versions fail to compile against it. (Upstreammainhassince dropped fmt for
std::format, so there is no 1.12.x release with a fix.)Known CI failure, disclosed up front.
fmt/[>=12 <13]resolves tofmt/12.2.0, and the compile then fails inException.hhregardless of where thesources are downloaded from — i.e. this is pre-existing and orthogonal to the URL
change. Measured locally with Conan 2.27.0, macOS armv8, apple-clang 21, varying
only the fmt version:
test_packageruns)no member named 'format' in namespace 'fmt'atException.hh:37Two options to make CI green, happy to do either here or in a follow-up —
whichever the team prefers:
#include <fmt/core.h>→#include <fmt/format.h>(verified: all four configurations below pass against fmt 12.2.0 with it).
Precedent for this shape exists, e.g.
rmmadds a missing<array>includevia
replace_in_file.fmt/[>=12 <12.2]— no source patching, but it blocksconsumers who need fmt 12.2.