Add bulk resource actions to web UI - #923
Open
AsoTora wants to merge 3 commits into
Open
Conversation
Signed-off-by: Andrei Shvedau <AsoTora@users.noreply.github.com> Assisted-by: Hermes Agent/gpt-5.5
Signed-off-by: Andrei Shvedau <AsoTora@users.noreply.github.com> Assisted-by: Hermes Agent/gpt-5.5
matheuscscp
reviewed
Jun 26, 2026
matheuscscp
left a comment
matheuscscp
left a comment
Member
There was a problem hiding this comment.
Thanks for this PR!
How does it look like? Is there a screenshot?
| // Validate action type | ||
| if !fluxcdv1.IsUserAction(actionReq.Action) { | ||
| // Validate action type. | ||
| if !isResourceAction(actionReq.Action) { |
Member
|
We can probably get this one in but we need some screenshots to start with |
Author
|
something like this No resources selected — bulk actions disabled
Two resources selected — bulk actions enabled
Select all visible resources — bulk actions enabled
|
Member
|
UI wise this doesn't look good to me, especially on mobile this now takes the whole view. We need to redesign the listing and integrate the actions into the status bar. Also why would we show selection and actions if RBAC does not allow it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/v1/resource/actionvalidation.Fixes #863.
Validation
make web-testmake web-buildKUBEBUILDER_ASSETS="$ASSETS" go test ./internal/web -count=1make testmake lintAI disclosure
Assisted-by: Hermes Agent/gpt-5.5