-
Notifications
You must be signed in to change notification settings - Fork 630
feat(jax): freeze models with hessian output #5608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
njzjz
wants to merge
6
commits into
deepmodeling:master
Choose a base branch
from
njzjz:feat/jax-hessian-freeze
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
91e4a09
feat(jax): freeze models with hessian output
njzjz 7d3223b
fix(jax): avoid mixed returns in serialization
njzjz 30735c1
test(jax): assert hessian freeze dispatch
njzjz 513f8df
Merge branch 'master' into feat/jax-hessian-freeze
njzjz 7f2b958
fix(jax): resolve hessian freeze merge conflict
njzjz bab82b1
fix(jax): skip unavailable hessian requests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
DERV_R_DERV_Rhere without aget_has_hessian()guard makes every JAX model requestenergy_derv_r_derv_r, including ones frozen without hessian.self.output_defis the consumer def fromDeepPot.output_def, which hard-codesr_hessian=True, so this category is always present (it is not gated onhessian_mode). For a non-hessian model the stablehlo/savedmodel never produces that key, so_eval_modelfalls into the fill branch and allocatesnp.full([nframes, 3*natoms, 3*natoms], nan)— an O(N^2) array (~72 MB at 1000 atoms) on the common non-atomic force/energy path — whichDeepPot.evalthen discards becauseget_has_hessian()is False.This reintroduces the regression fixed for the PT backend in #5045 ("fix: remove hessian outdef if not necessary", 87cb6ef). The PR already adds
get_has_hessian()(below), so the fix is to mirror pt (deepmd/pt/infer/deep_eval.py) and dropDERV_R_DERV_Rfrom the request defs whennot self.get_has_hessian().There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in bab82b1 by filtering
DERV_R_DERV_Rfrom JAX request definitions wheneverget_has_hessian()is false, matching the PyTorch backend behavior. Added regression coverage for standard non-Hessian models.Validation:
pytest source/tests/jax/test_training.py -k "deep_eval_requests_hessian or deep_eval_skips_hessian or main_dispatches_freeze or hlo_hessian_mode" -vruff check .ruff format --check .Coding agent: Codex
Codex version: codex-cli 0.144.1
Model: gpt-5.6-sol
Reasoning effort: xhigh