fix: allow undo of clear authorship colors without disconnect

.github/workflows/backend-tests.yml

@@ -124,14 +124,13 @@ jobs:
           ep_author_hover
           ep_cursortrace
           ep_font_size
-          ep_hash_auth
           ep_headings2
           ep_markdown
           ep_readonly_guest
           ep_set_title_on_pad
           ep_spellcheck
           ep_subscript_and_superscript
-          ep_table_of_contents   --runtimeVersion="${{ matrix.node }}"
+          ep_table_of_contents
       -
         name: Run the backend tests
         run: gnpm test   --runtimeVersion="${{ matrix.node }}"
@@ -232,22 +231,19 @@ jobs:
         run: gnpm build --runtimeVersion="${{ matrix.node }}"
       -
         name: Install Etherpad plugins
-        # The --legacy-peer-deps flag is required to work around a bug in npm
-        # v7: https://github.com/npm/cli/issues/2199
         run: >
           gnpm install --workspace-root
           ep_align
           ep_author_hover
           ep_cursortrace
           ep_font_size
-          ep_hash_auth
           ep_headings2
           ep_markdown
           ep_readonly_guest
           ep_set_title_on_pad
           ep_spellcheck
           ep_subscript_and_superscript
-          ep_table_of_contents   --runtimeVersion="${{ matrix.node }}"
+          ep_table_of_contents
       # Etherpad core dependencies must be installed after installing the
       # plugin's dependencies, otherwise npm will try to hoist common
       # dependencies by removing them from src/node_modules and installing them

.github/workflows/build-and-deploy-docs.yml

@@ -50,7 +50,7 @@ jobs:
         with:
           version: 0.0.12
       - name: Setup Pages
-        uses: actions/configure-pages@v5
+        uses: actions/configure-pages@v6
       - name: Install dependencies
         run: gnpm install
       - name: Build app
@@ -65,4 +65,4 @@ jobs:
           path: './doc/.vitepress/dist'
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v4
+        uses: actions/deploy-pages@v5

.github/workflows/docker.yml

@@ -30,13 +30,13 @@ jobs:
       -
         name: Set up QEMU
         if: github.event_name == 'push'
-        uses: docker/setup-qemu-action@v3
+        uses: docker/setup-qemu-action@v4
       -
         name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
       -
         name: Build and export to Docker
-        uses: docker/build-push-action@v6
+        uses: docker/build-push-action@v7
         with:
           context: ./etherpad
           target: production
@@ -82,7 +82,7 @@ jobs:
         name: Docker meta
         if: github.event_name == 'push'
         id: meta
-        uses: docker/metadata-action@v5
+        uses: docker/metadata-action@v6
         with:
           images: etherpad/etherpad
           tags: |
@@ -93,15 +93,15 @@ jobs:
       -
         name: Log in to Docker Hub
         if: github.event_name == 'push'
-        uses: docker/login-action@v3
+        uses: docker/login-action@v4
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_TOKEN }}
       -
         name: Build and push
         id: build-docker
         if: github.event_name == 'push'
-        uses: docker/build-push-action@v6
+        uses: docker/build-push-action@v7
         with:
           context: ./etherpad
           target: production

.github/workflows/frontend-admin-tests.yml

@@ -1,13 +1,15 @@
-# Leave the powered by Sauce Labs bit in as this means we get additional concurrency
 name: "Frontend admin tests"
 
 on:
   push:
     paths-ignore:
       - 'doc/**'
+  pull_request:
+    paths-ignore:
+      - 'doc/**'
 
 permissions:
-  contents: read # to fetch code (actions/checkout)
+  contents: read
 
 jobs:
   withplugins:
@@ -22,12 +24,6 @@ jobs:
         node: [20, 22, 24]
 
     steps:
-      -
-        name: Generate Sauce Labs strings
-        id: sauce_strings
-        run: |
-          printf %s\\n '::set-output name=name::${{ github.workflow }} - ${{ github.job }} - Node ${{ matrix.node }}'
-          printf %s\\n '::set-output name=tunnel_id::${{ github.run_id }}-${{ github.run_number }}-${{ github.job }}-node${{ matrix.node }}'
       -
         name: Checkout repository
         uses: actions/checkout@v6
@@ -47,38 +43,20 @@ jobs:
         uses: SamTV12345/gnpm-setup@main
         with:
           version: 0.0.12
-      - name: Cache playwright binaries
-        uses: actions/cache@v5
-        id: playwright-cache
-        with:
-          path: |
-            ~/.cache/ms-playwright
-          key: ${{ runner.os }}-playwright-${{ env.PLAYWRIGHT_VERSION }}
-      #-
-      #  name: Install etherpad plugins
-      #  # We intentionally install an old ep_align version to test upgrades to
-      #  # the minor version number. The --legacy-peer-deps flag is required to
-      #  # work around a bug in npm v7: https://github.com/npm/cli/issues/2199
-      #  run: pnpm install --workspace-root ep_align@0.2.27
-      # Etherpad core dependencies must be installed after installing the
-      # plugin's dependencies, otherwise npm will try to hoist common
-      # dependencies by removing them from src/node_modules and installing them
-      # in the top-level node_modules. As of v6.14.10, npm's hoist logic appears
-      # to be buggy, because it sometimes removes dependencies from
-      # src/node_modules but fails to add them to the top-level node_modules.
-      # Even if npm correctly hoists the dependencies, the hoisting seems to
-      # confuse tools such as `npm outdated`, `npm update`, and some ESLint
-      # rules.
       -
         name: Install all dependencies and symlink for ep_etherpad-lite
         run: gnpm i --runtimeVersion="${{ matrix.node }}"
-      #-
-      #  name: Install etherpad plugins
-      #  run: rm -Rf node_modules/ep_align/static/tests/*
-      -
-        name: export GIT_HASH to env
-        id: environment
-        run: echo "::set-output name=sha_short::$(git rev-parse --short ${{ github.sha }})"
+      - name: Cache Playwright browsers
+        uses: actions/cache@v5
+        id: playwright-cache
+        with:
+          path: ~/.cache/ms-playwright
+          key: ${{ runner.os }}-playwright-${{ hashFiles('src/package.json') }}
+      - name: Install Playwright browsers
+        if: steps.playwright-cache.outputs.cache-hit != 'true'
+        run: cd src && npx playwright install
+      - name: Install Playwright system dependencies
+        run: cd src && npx playwright install-deps
       -
         name: Create settings.json
         run: cp settings.json.template settings.json
@@ -96,33 +74,6 @@ jobs:
         working-directory: admin
         run: |
             gnpm run build --runtimeVersion="${{ matrix.node }}"
-      #  name: Run the frontend admin tests
-      #  shell: bash
-      #  env:
-      #    SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }}
-      #    SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}
-      #    SAUCE_NAME: ${{ steps.sauce_strings.outputs.name }}
-      #    TRAVIS_JOB_NUMBER: ${{ steps.sauce_strings.outputs.tunnel_id }}
-      #   GIT_HASH: ${{ steps.environment.outputs.sha_short }}
-      #  run: |
-      #    src/tests/frontend/travis/adminrunner.sh
-      #-
-      #  uses: saucelabs/sauce-connect-action@v2.3.6
-      #  with:
-      #    username: ${{ secrets.SAUCE_USERNAME }}
-      #    accessKey: ${{ secrets.SAUCE_ACCESS_KEY }}
-      #    tunnelIdentifier: ${{ steps.sauce_strings.outputs.tunnel_id }}
-      #-
-      #  name: Run the frontend admin tests
-      #  shell: bash
-      #  env:
-      #    SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }}
-      #    SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}
-      #    SAUCE_NAME: ${{ steps.sauce_strings.outputs.name }}
-      #    TRAVIS_JOB_NUMBER: ${{ steps.sauce_strings.outputs.tunnel_id }}
-      #   GIT_HASH: ${{ steps.environment.outputs.sha_short }}
-      #  run: |
-      #    src/tests/frontend/travis/adminrunner.sh
       - name: Run the frontend admin tests
         shell: bash
         run: |
@@ -138,10 +89,8 @@ jobs:
           sleep 1
           done
           cd src
-          gnpm exec playwright install --runtimeVersion="${{ matrix.node }}"
-          gnpm exec playwright install-deps --runtimeVersion="${{ matrix.node }}"
           gnpm run test-admin --runtimeVersion="${{ matrix.node }}"
-      - uses: actions/upload-artifact@v6
+      - uses: actions/upload-artifact@v7
         if: always()
         with:
           name: playwright-report-${{ matrix.node }}

.github/workflows/frontend-tests.yml

@@ -1,13 +1,15 @@
-# Leave the powered by Sauce Labs bit in as this means we get additional concurrency
-name: "Frontend tests powered by Sauce Labs"
+name: "Frontend tests"
 
 on:
   push:
     paths-ignore:
       - 'doc/**'
+  pull_request:
+    paths-ignore:
+      - 'doc/**'
 
 permissions:
-  contents: read # to fetch code (actions/checkout)
+  contents: read
 
 jobs:
   playwright-chrome:
@@ -16,12 +18,6 @@ jobs:
     name: Playwright Chrome
     runs-on: ubuntu-latest
     steps:
-      -
-        name: Generate Sauce Labs strings
-        id: sauce_strings
-        run: |
-          printf %s\\n '::set-output name=name::${{ github.workflow }} - ${{ github.job }}'
-          printf %s\\n '::set-output name=tunnel_id::${{ github.run_id }}-${{ github.run_number }}-${{ github.job }}'
       -
         name: Checkout repository
         uses: actions/checkout@v6
@@ -45,10 +41,6 @@ jobs:
       -
         name: Install all dependencies and symlink for ep_etherpad-lite
         run: gnpm install --frozen-lockfile
-      -
-        name: export GIT_HASH to env
-        id: environment
-        run: echo "::set-output name=sha_short::$(git rev-parse --short ${{ github.sha }})"
       -
         name: Create settings.json
         run: cp ./src/tests/settings.json settings.json
@@ -69,10 +61,10 @@ jobs:
           cd src
           gnpm exec playwright install chromium  --with-deps
           gnpm run test-ui --project=chromium
-      - uses: actions/upload-artifact@v6
+      - uses: actions/upload-artifact@v7
         if: always()
         with:
-          name: playwright-report-${{ matrix.node }}-chrome
+          name: playwright-report-chrome
           path: src/playwright-report/
           retention-days: 30
   playwright-firefox:
@@ -81,11 +73,6 @@ jobs:
     name: Playwright Firefox
     runs-on: ubuntu-latest
     steps:
-      - name: Generate Sauce Labs strings
-        id: sauce_strings
-        run: |
-          printf %s\\n '::set-output name=name::${{ github.workflow }} - ${{ github.job }}'
-          printf %s\\n '::set-output name=tunnel_id::${{ github.run_id }}-${{ github.run_number }}-${{ github.job }}'
       - name: Checkout repository
         uses: actions/checkout@v6
       - uses: actions/cache@v5
@@ -107,9 +94,6 @@ jobs:
           version: 0.0.12
       - name: Install all dependencies and symlink for ep_etherpad-lite
         run: gnpm install --frozen-lockfile
-      - name: export GIT_HASH to env
-        id: environment
-        run: echo "::set-output name=sha_short::$(git rev-parse --short ${{ github.sha }})"
       - name: Create settings.json
         run: cp ./src/tests/settings.json settings.json
       - name: Run the frontend tests
@@ -129,76 +113,9 @@ jobs:
           cd src
           gnpm exec playwright install firefox  --with-deps
           gnpm run test-ui --project=firefox
-      - uses: actions/upload-artifact@v6
+      - uses: actions/upload-artifact@v7
         if: always()
         with:
-          name: playwright-report-${{ matrix.node }}-firefox
+          name: playwright-report-firefox
           path: src/playwright-report/
           retention-days: 30
-  playwright-webkit:
-    name: Playwright Webkit
-    runs-on: ubuntu-latest
-    env:
-      PNPM_HOME: ~/.pnpm-store
-    steps:
-      -
-        name: Generate Sauce Labs strings
-        id: sauce_strings
-        run: |
-          printf %s\\n '::set-output name=name::${{ github.workflow }} - ${{ github.job }}'
-          printf %s\\n '::set-output name=tunnel_id::${{ github.run_id }}-${{ github.run_number }}-${{ github.job }}'
-      -
-        name: Checkout repository
-        uses: actions/checkout@v6
-      - uses: actions/cache@v5
-        name: Setup gnpm cache
-        if: always()
-        with:
-          path: |
-            ${{ env.PNPM_HOME }}
-            ~/.local/share/gnpm
-            ~/.cache/ms-playwright
-            /usr/local/bin/gnpm
-            /usr/local/bin/gnpm-0.0.12
-          key: ${{ runner.os }}-gnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
-          restore-keys: ${{ runner.os }}-gnpm-store-
-      - name: Setup gnpm
-        uses: SamTV12345/gnpm-setup@main
-        with:
-          version: 0.0.12
-      -
-        name: Install all dependencies and symlink for ep_etherpad-lite
-        run: gnpm install --frozen-lockfile
-      -
-        name: export GIT_HASH to env
-        id: environment
-        run: echo "::set-output name=sha_short::$(git rev-parse --short ${{ github.sha }})"
-      -
-        name: Create settings.json
-        run: cp ./src/tests/settings.json settings.json
-      - name: Run the frontend tests
-        shell: bash
-        run: |
-          gnpm run prod &
-          connected=false
-          can_connect() {
-          curl -sSfo /dev/null http://localhost:9001/ || return 1
-          connected=true
-          }
-          now() { date +%s; }
-          start=$(now)
-          while [ $(($(now) - $start)) -le 15 ] && ! can_connect; do
-          sleep 1
-          done
-          cd src
-          gnpm exec playwright install webkit --with-deps
-          gnpm run test-ui --project=webkit || true
-      - uses: actions/upload-artifact@v6
-        if: always()
-        with:
-          name: playwright-report-${{ matrix.node }}-webkit
-          path: src/playwright-report/
-          retention-days: 30
-
-
-

.github/workflows/load-test.yml

@@ -1,13 +1,9 @@
 name: "Loadtest"
 
-# any branch is useful for testing before a PR is submitted
 on:
-  push:
-    paths-ignore:
-      - "doc/**"
-  pull_request:
-    paths-ignore:
-      - "doc/**"
+  schedule:
+    - cron: '0 8 * * *'  # Daily at 08:00 UTC
+  workflow_dispatch:  # Allow manual trigger
 
 permissions:
   contents: read