chore: bump rustc to v1.95.0#10390
Merged
Merged
Conversation
…93e4d523493a7184283dfe87f8902 ic-build: sha256:43ddf2ae75392a94abe87301a3862f9a351ab96fda41e924843660c7f93c51f5 ic-dev: sha256:9fec9ba867951773d5461d08806f426a7b299f286177932a846b1a133d1ab6db
Contributor
|
Run URL: https://github.com/dfinity/ic/actions/runs/26965980770 New container images with tag: |
This reverts commit b435a83.
This reverts commit e5a66d5.
|
✅ No security or compliance issues detected. Reviewed everything up to d0ddf23. Security Overview
Detected Code Changes
|
|
✅ No security or compliance issues detected. Reviewed everything up to d0ddf23. Security Overview
Detected Code Changes
|
|
✅ No security or compliance issues detected. Reviewed everything up to d0ddf23. Security Overview
Detected Code Changes
|
mraszyk
dismissed
github-actions[bot]’s stale review
No canister behavior changes.
|
✅ No security or compliance issues detected. Reviewed everything up to 5f2866f. Security Overview
Detected Code Changes
|
|
✅ No security or compliance issues detected. Reviewed everything up to 5f2866f. Security Overview
Detected Code Changes
|
basvandijk
approved these changes
Jul 2, 2026
basvandijk
left a comment
basvandijk
left a comment
Collaborator
There was a problem hiding this comment.
I would recommend splitting the Rust changes from the upgrade itself such that a potential revert of the upgrade later (if problems arise) don't have to revert all those Rust changes.
tmu0
approved these changes
Jul 2, 2026
mbjorkqvist
approved these changes
Jul 2, 2026
mbjorkqvist
left a comment
mbjorkqvist
left a comment
Contributor
There was a problem hiding this comment.
DeFi changes LGTM, thanks @mraszyk!
Contributor
Author
Sure: #10637 |
alin-at-dfinity
approved these changes
Jul 2, 2026
alin-at-dfinity
left a comment
alin-at-dfinity
left a comment
Contributor
There was a problem hiding this comment.
Core Protocol changes LGTM.
# Conflicts: # .devcontainer/devcontainer.json # .github/workflows/api-bn-recovery-test.yml # .github/workflows/ci-main.yml # .github/workflows/ci-pr-only.yml # .github/workflows/container-api-bn-recovery.yml # .github/workflows/container-scan-nightly.yml # .github/workflows/local-system-tests.yml # .github/workflows/pocket-ic-tests-windows.yml # .github/workflows/rate-limits-backend-release.yml # .github/workflows/release-testing.yml # .github/workflows/rosetta-release.yml # .github/workflows/salt-sharing-canister-release.yml # .github/workflows/schedule-daily.yml # .github/workflows/schedule-rust-bench.yml # .github/workflows/system-tests-benchmarks-nightly.yml # .github/workflows/update-mainnet-canister-revisions.yaml # ci/container/TAG # rs/nns/governance/src/governance.rs # rs/recovery/src/app_subnet_recovery.rs # rs/recovery/src/nns_recovery_failover_nodes.rs # rs/recovery/src/nns_recovery_same_nodes.rs # rs/recovery/subnet_splitting/src/subnet_splitting.rs # rs/tests/ckbtc/ckdoge_minter_basics_test.rs
…5b0c3545ef1477f7b71c863030d51 ic-build: sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a ic-dev: sha256:87894a45bc67db8f923c4ea8f7a194d982d5c514f205451fba1f65d8f745d97d
Re-ran all benchmarks whose canbench results file is modified w.r.t. master and persisted the fresh numbers for the post-merge branch state. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
daniel-wong-dfinity-org-twin
approved these changes
Jul 8, 2026
basvandijk
pushed a commit
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the Rust version to v1.95.0.
Canbench summary
===================================================================================
ckBTC minter
target: //rs/bitcoin/ckbtc/minter:ckbtc_minter_canbench
results file: rs/bitcoin/ckbtc/minter/canbench/results.yml
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 7 | regressed 0 | improved 7 | new 0 | unchanged 0]
change: [max -163.50K | p75 -163.64K | median -163.68K | p25 -163.68K | min -164.78K]
change %: [max -38.39% | p75 -38.72% | median -38.78% | p25 -38.81% | min -38.99%]
heap_increase:
status: No significant changes 👍
counts: [total 7 | regressed 0 | improved 0 | new 0 | unchanged 7]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 7 | regressed 0 | improved 0 | new 0 | unchanged 7]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
Only significant changes:
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change
===================================================================================
ckETH minter
target: //rs/ethereum/cketh/minter:cketh_minter_canbench
results file: rs/ethereum/cketh/minter/canbench/results.yml
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 1 | regressed 0 | improved 1 | new 0 | unchanged 0]
change: [max -108.95M | p75 -108.95M | median -108.95M | p25 -108.95M | min -108.95M]
change %: [max -11.11% | p75 -11.11% | median -11.11% | p25 -11.11% | min -11.11%]
heap_increase:
status: No significant changes 👍
counts: [total 1 | regressed 0 | improved 0 | new 0 | unchanged 1]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 1 | regressed 0 | improved 0 | new 0 | unchanged 1]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
Only significant changes:
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change
===================================================================================
ICP ledger
target: //rs/ledger_suite/icp/ledger:ledger_canbench
results file: rs/ledger_suite/icp/ledger/canbench_results/canbench.yml
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 1 | regressed 0 | improved 1 | new 0 | unchanged 0]
change: [max -308.62M | p75 -308.62M | median -308.62M | p25 -308.62M | min -308.62M]
change %: [max -2.14% | p75 -2.14% | median -2.14% | p25 -2.14% | min -2.14%]
heap_increase:
status: No significant changes 👍
counts: [total 1 | regressed 0 | improved 0 | new 0 | unchanged 1]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 1 | regressed 0 | improved 0 | new 0 | unchanged 1]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
Only significant changes:
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change
===================================================================================
ICRC-1 ledger (u256)
target: //rs/ledger_suite/icrc1/ledger:canbench_u256
results file: rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u256.yml
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 2 | regressed 0 | improved 1 | new 0 | unchanged 1]
change: [max -21.14K | p75 -883.02M | median -1.77B | p25 -2.65B | min -3.53B]
change %: [max -0.24% | p75 -1.82% | median -3.39% | p25 -4.97% | min -6.54%]
heap_increase:
status: No significant changes 👍
counts: [total 2 | regressed 0 | improved 0 | new 0 | unchanged 2]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 2 | regressed 0 | improved 0 | new 0 | unchanged 2]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
Only significant changes:
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change
===================================================================================
ICRC-1 ledger (u64)
target: //rs/ledger_suite/icrc1/ledger:canbench_u64
results file: rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u64.yml
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 2 | regressed 0 | improved 1 | new 0 | unchanged 1]
change: [max -20.83K | p75 -871.90M | median -1.74B | p25 -2.62B | min -3.49B]
change %: [max -0.24% | p75 -1.84% | median -3.45% | p25 -5.05% | min -6.65%]
heap_increase:
status: No significant changes 👍
counts: [total 2 | regressed 0 | improved 0 | new 0 | unchanged 2]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 2 | regressed 0 | improved 0 | new 0 | unchanged 2]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
Only significant changes:
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change
===================================================================================
NNS governance
target: //rs/nns/governance:governance-canbench
results file: rs/nns/governance/canbench/canbench_results.yml
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 28 | regressed 0 | improved 3 | new 0 | unchanged 25]
change: [max +924.98K | p75 -852 | median -60.22K | p25 -465.20K | min -3.14M]
change %: [max +1.62% | p75 -0.76% | median -2.24% | p25 -2.78% | min -7.58%]
heap_increase:
status: No significant changes 👍
counts: [total 28 | regressed 0 | improved 0 | new 0 | unchanged 28]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 28 | regressed 0 | improved 0 | new 0 | unchanged 28]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
Only significant changes:
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change
===================================================================================
Registry canister
target: //rs/registry/canister:registry-canbench
results file: rs/registry/canister/canbench/canbench_results.yml
Summary:
instructions:
status: Improvements detected 🟢
counts: [total 14 | regressed 0 | improved 10 | new 0 | unchanged 4]
change: [max -5 | p75 -1.15M | median -10.78M | p25 -32.86M | min -1.30B]
change %: [max -0.00% | p75 -0.63% | median -3.09% | p25 -9.71% | min -13.80%]
heap_increase:
status: No significant changes 👍
counts: [total 14 | regressed 0 | improved 0 | new 0 | unchanged 14]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
stable_memory_increase:
status: No significant changes 👍
counts: [total 14 | regressed 0 | improved 0 | new 0 | unchanged 14]
change: [max 0 | p75 0 | median 0 | p25 0 | min 0]
change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%]
Only significant changes:
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change