feat: use git-derived version in container image - #422
Draft
Mogyuchi wants to merge 1 commit into
Draft
Conversation
Mogyuchi
force-pushed
the
git-derived-version
branch
from
June 5, 2024 10:51
be0a8f1 to
91b3d8e
Compare
Mogyuchi
force-pushed
the
git-derived-version
branch
from
June 5, 2024 10:55
91b3d8e to
5528e65
Compare
Mogyuchi
marked this pull request as ready for review
June 5, 2024 11:01
cm-ayf
reviewed
Jun 6, 2024
Mogyuchi
marked this pull request as draft
June 6, 2024 17:46
Collaborator
|
package.jsonのversionプロパティをいじるのは良くないのでは？ということで別の方法を模索中 |
Collaborator
Author
|
esbuild-plugin-version-injector が deprecated になっているので、unplugin-replace に変更する。 |
Collaborator
|
unplugin-replace にするなら、package.json#version 以外に文字列渡せそうね |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gitオブジェクトに基づくバージョンを使うようにします。
これにより、
edgeイメージなどにおけるバージョン表示の情報量を増やします。