resolve build dependency conflict for urllib3, unify python version to 3.9.13 - #153
Merged
Conversation
Problem: the espn_api dependency list is conflicting, and causes a build
failure when trying to compose the docker image. Additionally, the
python version is set to different versions across the repo
```
[...]
> [4/4] RUN python setup.py install:
2.777 Searching for certifi>=2017.4.17
2.777 Reading https://pypi.org/simple/certifi/
2.858 Downloading https://files.pythonhosted.org/packages/e5/48/1549795ba7742c948d2ad169c1c8cdbae65bc450d6cd753d124b17c8cd32/certifi-2025.8.3-py3-none-any.whl#sha256=f6c12493cfb1b06ba2ff328595af9350c65d6644968e5d3a2ffd78699af217a5
2.899 Best match: certifi 2025.8.3
2.899 Processing certifi-2025.8.3-py3-none-any.whl
2.901 Installing certifi-2025.8.3-py3-none-any.whl to /usr/local/lib/python3.9/site-packages
2.909 Adding certifi 2025.8.3 to easy-install.pth file
2.911
2.911 Installed /usr/local/lib/python3.9/site-packages/certifi-2025.8.3-py3.9.egg
2.911 error: urllib3 2.5.0 is installed but urllib3<=2.2.3 is required by {'espn-api'}
[...]
```
Solution: set the urllib3 dependency to be explicitly <=2.2.3, the same
version expected by espn_api currently. Additionally, updated the python
version to be explicitly 3.9.13 across the repo. additionally removed
deprecated version tag from the docker compose file
Testing: was able to successfully run `docker compose up -d` using the
new config
```
[+] Running 2/2
✔ fantasy_football_chat_bot-gamedaybot Built 0.0s
✔ Container fantasy_football_chat_bot-gamedaybot-1 Started
```
Owner
|
Thank you for the PR. Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
versiontagSolution:
Testing: was able to successfully run
docker compose up -dusing the new config, and the github test action workflows passed in my fork on push