Skip to content

Fix folder delete confirmation for names with special characters - #4229

Merged
devkiran merged 1 commit into
mainfrom
fix/folder-delete-confirmation
Jul 28, 2026
Merged

Fix folder delete confirmation for names with special characters#4229
devkiran merged 1 commit into
mainfrom
fix/folder-delete-confirmation

Conversation

@devkiran

@devkiran devkiran commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Require typing "confirm delete folder" instead of the folder name so HTML pattern validation no longer fails on names like "Forms (Internal)".

Summary by CodeRabbit

  • Bug Fixes
    • Updated folder deletion confirmation to require the phrase “confirm delete folder,” providing a consistent and clear verification step.

Require typing "confirm delete folder" instead of the folder name so HTML pattern validation no longer fails on names like "Forms (Internal)".
@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dub Ready Ready Preview Jul 28, 2026 9:04am

Request Review

@devkiran
devkiran requested a review from pepeladeira July 28, 2026 08:54
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 584d4d2d-c573-4233-aafa-81591b99c43f

📥 Commits

Reviewing files that changed from the base of the PR and between 4dc7b19 and dda41b7.

📒 Files selected for processing (1)
  • apps/web/ui/modals/delete-folder-modal.tsx

📝 Walkthrough

Walkthrough

DeleteFolderModal now requires users to enter the fixed phrase "confirm delete folder" in the confirmation prompt and input validation. Submission handling and API behavior remain unchanged.

Changes

Folder deletion confirmation

Layer / File(s) Summary
Fixed confirmation phrase
apps/web/ui/modals/delete-folder-modal.tsx
The modal prompt and input pattern now use "confirm delete folder" instead of the current folder name.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main fix: folder delete confirmation now uses a fixed phrase to avoid special-character name issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/folder-delete-confirmation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devkiran
devkiran merged commit 7be9868 into main Jul 28, 2026
13 checks passed
@devkiran
devkiran deleted the fix/folder-delete-confirmation branch July 28, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants