Implemented custom SNI server name - #1582
Open
fpagliughi wants to merge 2 commits into
Open
Conversation
fpagliughi
force-pushed
the
custom-sni-validation
branch
from
March 1, 2025 15:49
1a9ca71 to
edf5f76
Compare
Contributor
Author
|
It took two tries, but this appears to be working now and passing all the unit tests. The simplest test for this is to use the IP address in the URL and then set the A thing to note is that this only allows for providing a single server name, even when using High Availability with multiple URLs. If you omit the server name, each host name will be derived from the URL, just like before, but if you do add a server name, all addresses will verify to that name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #1580, to provide an optional, separate SNI server name.
It adds a new
const char* serverNameparameter to the SSL options. If it is non-NULL, then it is used for SNI validation, otherwise the host name is used. Thus the new capability is opt-in, and defaults to the previous implementation if not provided, and therefore is completely backward compatible.