Fixed CMake build so that CPack is only pulled in for PAHO_CPACK_ENAB… - #1665
Open
fpagliughi wants to merge 1 commit into
Open
Fixed CMake build so that CPack is only pulled in for PAHO_CPACK_ENAB…#1665fpagliughi wants to merge 1 commit into
fpagliughi wants to merge 1 commit into
Conversation
This was referenced Mar 30, 2026
|
Any chance this will be merged in the next release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1654
CPack was being enabled and some CPACK variables were set, even when PAHO_ENABLE_CPACK=OFF.
This PR:
include(CPack)and set(CPACK_PACKAGE_...)` into a conditional blockPAHO_ENABLE_CPACKifPAHO_BUILD_DEB_PACKAGEis set (since it's now required as the DEB builder uses CPack)