cmd/geth: propagate import error when --nocompaction is set#35152
Open
cuiweixie wants to merge 1 commit into
Open
cmd/geth: propagate import error when --nocompaction is set#35152cuiweixie wants to merge 1 commit into
cuiweixie wants to merge 1 commit into
Conversation
importChain records the first import failure in importErr, logs it, and returns it at the end of the function so that "geth import" exits with a non-zero status on failure. However, the --nocompaction early return returned nil instead of importErr, so an import that failed while that flag was set was reported as success (exit code 0). This silently masked import failures from any script or CI step that relies on the exit code. Return importErr from the early-return path as well, matching the normal (compacting) path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
importChain records the first import failure in importErr, logs it, and returns it at the end of the function so that "geth import" exits with a non-zero status on failure. However, the --nocompaction early return returned nil instead of importErr, so an import that failed while that flag was set was reported as success (exit code 0).
This silently masked import failures from any script or CI step that relies on the exit code. Return importErr from the early-return path as well, matching the normal (compacting) path.