.: archival rebased on top of bal devnet 7#35160
Draft
gballet wants to merge 17 commits into
Draft
Conversation
Might not actually be needed if spec is changed, see ethereum/EIPs#11699
gballet
force-pushed
the
archival-command-bal-7
branch
from
ccf77e1 to
4a152aa
Compare
gballet
changed the title
gballet
force-pushed
the
archival-command-bal-7
branch
from
4a152aa to
c5afdd8
Compare
Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: tellabg <249254436+tellabg@users.noreply.github.com>
gballet
force-pushed
the
archival-command-bal-7
branch
from
c5afdd8 to
3e6e4f1
Compare
MariusVanDerWijden
force-pushed
the
bal-devnet-7
branch
from
f773cfe to
9e04883
Compare
…577) The nodeHeight *fullNode case returned maxHeight+1 once the running max height reached maxHeight via one child: the `if maxH+1 > maxHeight` guard fired on the next hashNode child, reporting a genuine height-3 branch as height 4. With the `height == 3` archival predicate this made dense, branch-heavy tries (notably the account trie, whose height-3 nodes are all multi-child branches) archive nothing, while only sparse, extension-heavy storage tries archived anything. On a jochemnet shadowfork (path scheme, ~379 GB live KV) a 15.5h `archive generate` archived only 122,340 subtrees / 16.6 MB, and the account trie archived nothing (count=0), with zero read/collection failures in the log -- confirming a height computation bug rather than a read-path issue. Replace the running-max guard with a depth-budget guard mirroring the already-correct *shortNode case; keep the post-update `maxH > maxHeight` exceeded check so recursion and raw-DB reads stay bounded. Add trie/archiver_test.go: a height-3 root branch probes as height 3 (it returned 4 before this change). Co-authored-by: CPerezz <claude.ai.monorail916@passmail.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.