cmd/devp2p/ethtest: fix swapped args in private-key error message#35193
Open
ozpool wants to merge 1 commit into
Open
cmd/devp2p/ethtest: fix swapped args in private-key error message#35193ozpool wants to merge 1 commit into
ozpool wants to merge 1 commit into
Conversation
The error "unable to read private key for %s: %v" passed (err, addr), so it printed the decode error where the account address belongs and the address where the error belongs. Swap to (addr, err) so the message names the account that failed and then the reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading the ethtest sender-loading path I noticed the error for a failed key decode passes its arguments in the wrong order:
The format string is
for %s: %v(address, then reason), but the arguments are(err, addr). So the message prints the decode error where the account address should be and the address where the reason should be, e.g.:Swapping to
(addr, err)makes it read as intended:go build ./cmd/devp2p/...andgo vet ./cmd/devp2p/internal/ethtest/pass.