ethclient: add test coverage for RevertErrorData with EstimateGas#35197
Open
ShauryaaSharma wants to merge 1 commit into
Open
ethclient: add test coverage for RevertErrorData with EstimateGas#35197ShauryaaSharma wants to merge 1 commit into
ShauryaaSharma wants to merge 1 commit into
Conversation
RevertErrorData was added in ethereum#30669 with a doc comment stating it works for both CallContract and EstimateGas, but only a CallContract example existed. Add ExampleRevertErrorData_estimateGas to document the EstimateGas path and TestRevertErrorData to verify both paths return identical revert bytes and that non-revert errors are correctly rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RevertErrorData was added in #30669 to let callers extract EVM revert bytes from errors returned by contract calls. Its doc comment states the function works for both CallContract and EstimateGas, but only a CallContract example existed; the EstimateGas path had no test or documentation, leaving it unverified.
This change adds ExampleRevertErrorData_estimateGas to document the EstimateGas usage and TestRevertErrorData to assert that both methods return identical revert bytes for a reverting contract, and that plain non-revert errors are correctly rejected by the function.
Fixes #27539.