-
Notifications
You must be signed in to change notification settings - Fork 2
456: catalog update nox task descriptions #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 4 commits
b4b053c
b294fcc
8e169eb
d9c950d
b885db7
dd1b387
a2255e0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,10 @@ | ||
| # Unreleased | ||
|
|
||
| ## Summary | ||
|
|
||
| This release documents how to discover and use PTB's Nox sessions in the user | ||
| guide and removes the unused Modules section from the developer guide. | ||
|
|
||
| ## Documentation | ||
|
|
||
| * #456: Documented how to discover PTB nox sessions in the user guide and removed the unused developer-guide Modules section |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,4 +9,3 @@ | |
|
|
||
| ../design | ||
| plugins | ||
| modules/modules | ||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,9 +88,13 @@ def test_without_existing_github_issue_passes_through( | |
| json_path = tmp_path / "input.json" | ||
| json_path.write_text(sample_maven_vulnerabilities.issues_json) | ||
|
|
||
| result = cli_runner.invoke( | ||
| CVE_CLI, ["filter", Filter.GitHubIssues.value, str(json_path)] | ||
| ) | ||
| with patch( | ||
| "exasol.toolbox.tools.security.gh_security_issues", | ||
| return_value=(), | ||
| ): | ||
| result = cli_runner.invoke( | ||
| CVE_CLI, ["filter", Filter.GitHubIssues.value, str(json_path)] | ||
| ) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. after removing GITHUB_TOKEN, the CI failed, so i had to add
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did you remove I think this test was designed as an integration test and should not patch the access to GitHub. The fix is rather to ensure having a GitHub token. I propose to re-add GitHub token to file
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I had suggested removing it. It's an artifact in many of the repositories but not in this case, it appears. |
||
|
|
||
| assert result.exit_code == 0 | ||
| assert result.output.strip() == sample_maven_vulnerabilities.issues_json | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.