Skip to content
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-publish.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/check-release-tag.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions .github/workflows/checks.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/dependency-update.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/fast-tests.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/gh-pages.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/matrix.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/report.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions .github/workflows/slow-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ jobs:
runs-on: "ubuntu-24.04"
permissions:
contents: read
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Comment thread
ArBridgeman marked this conversation as resolved.
strategy:
fail-fast: false
matrix: ${{ fromJson(needs.build-matrix.outputs.matrix) }}
Expand All @@ -33,7 +31,7 @@ jobs:

- name: Set up Python & Poetry Environment
id: set-up-python-and-poetry-environment
uses: exasol/python-toolbox/.github/actions/python-environment@v8
uses: exasol/python-toolbox/.github/actions/python-environment@v10
with:
python-version: ${{ matrix.python_versions }}
poetry-version: "2.3.0"
Expand Down
7 changes: 7 additions & 0 deletions doc/changes/unreleased.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# Unreleased

## Summary

This release documents how to discover and use PTB's Nox sessions in the user
guide and removes the unused Modules section from the developer guide.

## Documentation

* #456: Documented how to discover PTB nox sessions in the user guide and removed the unused developer-guide Modules section
1 change: 0 additions & 1 deletion doc/developer_guide/developer_guide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@

../design
plugins
modules/modules
7 changes: 0 additions & 7 deletions doc/developer_guide/modules/modules.rst

This file was deleted.

14 changes: 0 additions & 14 deletions doc/developer_guide/modules/nox_tasks.rst

This file was deleted.

14 changes: 14 additions & 0 deletions doc/user_guide/features/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,17 @@ Important Nox Commands

* :code:`nox -l` shows a list of all available nox sessions
* :code:`nox -s <session>` run the specified session(s)

The command :code:`nox -l` is the most reliable way to see the full current
session list for your project.

Common examples are:

* :code:`nox -s format:fix` to apply formatting changes
* :code:`nox -s project:check` to run the main local quality gate
* :code:`nox -s test:unit` to run unit tests
* :code:`nox -s workflow:generate -- all` to regenerate PTB workflows

Use the feature pages in this guide for task-specific details, for example
formatting, GitHub workflows, dependency management, release preparation, and
code-quality reporting.
10 changes: 7 additions & 3 deletions test/integration/tools/security_integration_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,13 @@ def test_without_existing_github_issue_passes_through(
json_path = tmp_path / "input.json"
json_path.write_text(sample_maven_vulnerabilities.issues_json)

result = cli_runner.invoke(
CVE_CLI, ["filter", Filter.GitHubIssues.value, str(json_path)]
)
with patch(
"exasol.toolbox.tools.security.gh_security_issues",
return_value=(),
):
result = cli_runner.invoke(
CVE_CLI, ["filter", Filter.GitHubIssues.value, str(json_path)]
)

@jana-selva jana-selva Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after removing GITHUB_TOKEN, the CI failed, so i had to add with block to fix on that.. is this right or should i think of different approach ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove GITHUB_TOKEN in the first place?

I think this test was designed as an integration test and should not patch the access to GitHub.
It should also not patch the access to GitHub when there is no GitHub Token.

The fix is rather to ensure having a GitHub token.

I propose to re-add GitHub token to file slow-checks.yml.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I had suggested removing it. It's an artifact in many of the repositories but not in this case, it appears.


assert result.exit_code == 0
assert result.output.strip() == sample_maven_vulnerabilities.issues_json
Expand Down