Bugfix/898 improve code related to bug in dependency update#915
Open
ArBridgeman wants to merge 15 commits into
Open
Bugfix/898 improve code related to bug in dependency update#915ArBridgeman wants to merge 15 commits into
ArBridgeman wants to merge 15 commits into
Conversation
kratz00
reviewed
Jul 6, 2026
| Check for vulnerable dependencies, and if present, attempt to update dependencies. | ||
| """ | ||
| initial_report = self._get_report_json() | ||
| print(initial_report) |
Contributor
There was a problem hiding this comment.
Move the print after the check and print a dedicated message, instead of "[]"?
Contributor
There was a problem hiding this comment.
Or maybe move all the "printing" to the caller and let it decide.
|
kratz00
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




closes #898
Checklist
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
For any Pull Request
Is the following correct:
When Changes Were Made
Did you:
When Preparing a Release
Have you: