Skip to content

Bugfix/898 improve code related to bug in dependency update#915

Open
ArBridgeman wants to merge 15 commits into
mainfrom
bugfix/898_improve_bug_in_dependency_update
Open

Bugfix/898 improve code related to bug in dependency update#915
ArBridgeman wants to merge 15 commits into
mainfrom
bugfix/898_improve_bug_in_dependency_update

Conversation

@ArBridgeman

Copy link
Copy Markdown
Collaborator

closes #898

Checklist

Note: If any of the items in the checklist are not relevant to your PR, just check the box.

For any Pull Request

Is the following correct:

  • the title of the Pull Request?
  • the title of the corresponding issue?
  • there are no other open Pull Requests for the same update/change?
  • that the issue which this Pull Request fixes ("Fixes...") is mentioned?

When Changes Were Made

Did you:

  • update the changelog?
  • update the cookiecutter-template?
  • update the implementation?
  • check coverage and add tests: unit tests and, if relevant, integration tests?
  • update the User Guide & other documentation?
  • resolve any failing CI criteria (incl. Sonar quality gate)?

When Preparing a Release

Have you:

  • thought about version number (major, minor, patch)?
  • checked Exasol packages for updates and resolved open vulnerabilities, if easily possible?

@ArBridgeman ArBridgeman temporarily deployed to manual-approval July 6, 2026 10:10 — with GitHub Actions Inactive
@ArBridgeman ArBridgeman temporarily deployed to manual-approval July 6, 2026 10:10 — with GitHub Actions Inactive
@ArBridgeman ArBridgeman changed the title Bugfix/898 improve bug in dependency update Bugfix/898 improve code related to bug in dependency update Jul 6, 2026
Comment thread doc/changes/unreleased.md Outdated
Check for vulnerable dependencies, and if present, attempt to update dependencies.
"""
initial_report = self._get_report_json()
print(initial_report)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the print after the check and print a dedicated message, instead of "[]"?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe move all the "printing" to the caller and let it decide.

@ArBridgeman ArBridgeman deployed to manual-approval July 6, 2026 12:26 — with GitHub Actions Active
@ArBridgeman ArBridgeman temporarily deployed to manual-approval July 6, 2026 12:26 — with GitHub Actions Inactive
@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve jq in dependency-update.yml

2 participants