Skip to content

This PR is to add comments to TestSyncScheduleInfoToCacheNodes in pkg/ddc/efc/node_test.go. #6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LingHangwangxianjiui wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

This PR is to add comments to TestSyncScheduleInfoToCacheNodes in pkg/ddc/efc/node_test.go. #6075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/ddc/efc/node_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ func getTestEFCEngineNode(client client.Client, name string, namespace string, w
}
return engine
}

// TestSyncScheduleInfoToCacheNodes verifies that SyncScheduleInfoToCacheNodes

@cheyang cheyang Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small style nit: the blank line that used to separate the closing brace of getTestEFCEngineNode from the next declaration was removed when the doc comment was added, so the helper and the new // TestSyncScheduleInfoToCacheNodes ... block now sit visually glued together. Restoring a single blank line before the comment keeps this file aligned with the rest of the package style.

// correctly synchronizes scheduling information to cache nodes by updating
// node labels based on the locations of worker pods. It covers scenarios
// including creating new labels, adding labels to existing nodes, and
// skipping synchronization when the worker pod has no controller.
func TestSyncScheduleInfoToCacheNodes(t *testing.T) {
type fields struct {
// runtime *datav1alpha1.EFCRuntime
Expand Down
Loading