Add comments to needReseThis PR is to add comments to needResetReservedPorts in fluid/pkg/ddc/base/portallocator/bitmap_allocator.go.tReservedPorts in fluid/pkg/ddc/base/portallo…#6096
Conversation
…cator/bitmap_allocator.go.
There was a problem hiding this comment.
Code Review
This pull request adds a descriptive comment to the needResetReservedPorts method in bitmap_allocator.go to explain its purpose. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
@withanorchid22 — this PR is blocked from merging by a failing DCO check. Please resolve this now. For a single-commit PR: For multiple commits on this branch: The code review side is finished and any merge labels already on the PR will take effect once DCO turns green. Reference: https://github.com/apps/dco |
|
/copilot review |
| log logr.Logger | ||
| } | ||
|
|
||
| // needResetReservedPorts reports whether the bitmap allocator needs to reset |
There was a problem hiding this comment.
Small nit: the blank line between the BitMapAllocator struct's closing } and the new godoc block was removed, so the comment now runs straight into the type declaration. Could you keep a blank line here so the doc comment stays visually attached to needResetReservedPorts rather than to the struct? The wording of the comment itself is fine.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6096 +/- ##
=======================================
Coverage 64.76% 64.76%
=======================================
Files 484 484
Lines 33885 33885
=======================================
Hits 21947 21947
Misses 10215 10215
Partials 1723 1723 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @withanorchid22. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |



I. Describe what this PR does
This PR adds function-level comments to needResetReservedPorts in fluid/pkg/ddc/base/portallocator/bitmap_allocator.go. The comments describe that the function checks whether the bitmap allocator needs to reset its reserved port state before allocating ports.
II. Does this pull request fix one issue?
fixes #6095
III. Special notes for reviews
None.