[camera_android_camerax] Pass targetVideoEncodingBitRate to Recorder#11960
[camera_android_camerax] Pass targetVideoEncodingBitRate to Recorder#11960Anantha-Eswar wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the camera_android_camerax package to version 0.7.3, fixing an issue where the videoBitrate configuration was ignored during video recording. The Recorder is now instantiated with targetVideoEncodingBitRate mapped from mediaSettings?.videoBitrate, and unit tests have been updated to verify this configuration. There are no review comments, and I have no feedback to provide.
This PR fixes an issue where the
videoBitrateparameter configured inMediaSettingswas ignored during video recording on Android using CameraX.We now forward
mediaSettings?.videoBitrateas thetargetVideoEncodingBitRatewhen instantiating the CameraXRecorderinstance inAndroidCameraCameraX.createCameraWithSettings.Fixes flutter/flutter#179832
Pre-Review Checklist
[shared_preferences]///).