Skip to content

[Decoupling] Port flutter/flutter #184808 "Remove semantics_tester import from card_test.dart" #11965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
justinmc wants to merge 7 commits into
base: main
Choose a base branch
from
+20 −46
Draft

[Decoupling] Port flutter/flutter #184808 "Remove semantics_tester import from card_test.dart" #11965

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f9ec54
Remove semantics_tester import from card_test.dart
Sanaullah49 Apr 9, 2026
4be58a3
Address review feedback on Card semantics tests
Sanaullah49 Apr 9, 2026
f34c122
Use addTearDown for card semantics handles
Sanaullah49 Apr 9, 2026
07ad7c9
Dispose card semantics handles with try-finally
Sanaullah49 Apr 28, 2026
bd64394
Address review feedback: use addTearDown instead of try/finally
Sanaullah49 May 5, 2026
2b1a712
Remove unnecessary rendering.dart import from card_test.dart
Sanaullah49 May 6, 2026
00e90fc
Fix leaking SemanticsHandle in card semantics tests
Sanaullah49 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 20 additions & 46 deletions packages/material_ui/temporarily_disabled_tests/card_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.',
)
import 'package:material_ui/material_ui.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter_test/flutter_test.dart';
import '../widgets/semantics_tester.dart';

void main() {
testWidgets('Material3 - Card defaults (Elevated card)', (WidgetTester tester) async {
Expand Down Expand Up @@ -93,7 +91,6 @@ void main() {
});

testWidgets('Card can take semantic text from multiple children', (WidgetTester tester) async {
final semantics = SemanticsTester(tester);
await tester.pumpWidget(
Directionality(
textDirection: TextDirection.ltr,
Expand All @@ -115,38 +112,29 @@ void main() {
);

expect(
semantics,
hasSemantics(
TestSemantics.root(
children: <TestSemantics>[
TestSemantics(id: 1, label: 'I am text!', textDirection: TextDirection.ltr),
TestSemantics(id: 2, label: 'Moar text!!1', textDirection: TextDirection.ltr),
TestSemantics(
id: 3,
label: 'Button',
textDirection: TextDirection.ltr,
actions: <SemanticsAction>[SemanticsAction.tap, SemanticsAction.focus],
flags: <SemanticsFlag>[
SemanticsFlag.hasEnabledState,
SemanticsFlag.isButton,
SemanticsFlag.isEnabled,
SemanticsFlag.isFocusable,
],
),
],
),
ignoreTransform: true,
ignoreRect: true,
tester.getSemantics(find.text('I am text!')),
matchesSemantics(label: 'I am text!', textDirection: TextDirection.ltr),
);
expect(
tester.getSemantics(find.text('Moar text!!1')),
matchesSemantics(label: 'Moar text!!1', textDirection: TextDirection.ltr),
);
expect(
tester.getSemantics(find.widgetWithText(ElevatedButton, 'Button')),
matchesSemantics(
label: 'Button',
textDirection: TextDirection.ltr,
hasTapAction: true,
hasFocusAction: true,
hasEnabledState: true,
isButton: true,
isEnabled: true,
isFocusable: true,
),
);

semantics.dispose();
});

testWidgets('Card merges children when it is a semanticContainer', (WidgetTester tester) async {
final semantics = SemanticsTester(tester);
debugResetSemanticsIdCounter();

await tester.pumpWidget(
const Directionality(
textDirection: TextDirection.ltr,
Expand All @@ -161,23 +149,9 @@ void main() {
);

expect(
semantics,
hasSemantics(
TestSemantics.root(
children: <TestSemantics>[
TestSemantics(
id: 1,
label: 'First child\nSecond child',
textDirection: TextDirection.ltr,
),
],
),
ignoreTransform: true,
ignoreRect: true,
),
tester.getSemantics(find.byType(Card)),
matchesSemantics(label: 'First child\nSecond child', textDirection: TextDirection.ltr),
);

semantics.dispose();
});

testWidgets('Card margin', (WidgetTester tester) async {
Expand Down
Loading