Skip to content

perf(core): [SDK Overhead Reduction 6] Reduce JsonWriter stack allocation #5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adinauer wants to merge 1 commit into
base: perf/sdk-overhead-reduction
Choose a base branch
from
+2 −2
Draft

perf(core): [SDK Overhead Reduction 6] Reduce JsonWriter stack allocation #5591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sentry/src/main/java/io/sentry/vendor/gson/stream/JsonWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
// Source: https://github.com/google/gson
// Tag: gson-parent-2.8.7
// Commit Hash: 4520489c29e770c64b11ca35e0a0fdf17a1874ab
// Changes: @ApiStatus.Internal, SuppressWarnings
// Changes: @ApiStatus.Internal, SuppressWarnings, reduced stack size

package io.sentry.vendor.gson.stream;

Expand Down Expand Up @@ -175,7 +175,7 @@ public class JsonWriter implements Closeable, Flushable {
/** The output data, containing at most one top-level array or object. */
private final Writer out;

private int[] stack = new int[32];
private int[] stack = new int[8];
private int stackSize = 0;
{
push(EMPTY_DOCUMENT);
Expand Down
Loading