Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SDK MCP OAuth host token handlers #1669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Add SDK MCP OAuth host token handlers #1669
Changes from all commits
6717285ae75af82a2faa1ccc403f1cd18026d3d655ea3d85fFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check notice
Code scanning / CodeQL
Generic catch clause Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross-SDK consistency suggestion:
McpAuthContextis missing aRequestIdproperty.Every other SDK exposes the request ID to the MCP auth handler:
McpAuthRequest.requestIdMcpAuthRequest["requestId"](TypedDict key)MCPAuthRequest.RequestIDMcpAuthRequest.requestId()(record component)request_id: RequestIdas a separatehandle()parameterIn .NET, a handler receiving an MCP OAuth request has no way to identify or log which specific request it's processing. Consider adding:
(The existing .NET
PermissionInvocationalso omits request ID, so there is a consistent internal precedent — but for the newMcpAuthContexttype this cross-SDK gap is worth revisiting.)Check failure on line 70 in dotnet/test/E2E/McpOAuthE2ETests.cs
Check failure on line 70 in dotnet/test/E2E/McpOAuthE2ETests.cs
Check notice
Code scanning / CodeQL
Call to 'System.IO.Path.Combine' may silently drop its earlier arguments Note test
Check notice
Code scanning / CodeQL
Call to 'System.IO.Path.Combine' may silently drop its earlier arguments Note test
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.