[Repo Assist] fix(httputil): remove duplicate TLS declarations

[github-actions]

🤖 This PR is from Repo Assist, an automated AI assistant for this repository.

Closes #7862

Root Cause

After PR #7834 was merged (which introduced internal/httputil/tls.go), a second file internal/httputil/tls_config.go was added to the same package with identical declarations for MinTLSVersion, NewServerTLSConfig, and NewClientTLSConfig. Go does not permit two files in the same package to define the same exported identifiers — this causes a compile error:

internal/httputil/tls_config.go:7:7: MinTLSVersion redeclared in this block
internal/httputil/tls_config.go:11:6: NewServerTLSConfig redeclared in this block
internal/httputil/tls_config.go:20:6: NewClientTLSConfig redeclared in this block

Fix

• Delete internal/httputil/tls_config.go — tls.go is kept as it has more detailed godoc
• Delete internal/httputil/tls_config_test.go — tls_test.go is kept
• Absorb assert.NotNil checks from tls_config_test.go into tls_test.go so no test coverage is lost

No production logic changes — only the duplicate file is removed.

Test Status

⚠️ Infrastructure note: proxy.golang.org is blocked by the environment firewall, preventing go build ./... and go test ./....

Manual verification performed:

• go tool compile -e internal/httputil/tls.go — after removing tls_config.go, no redeclaration errors remain (only the expected "could not import crypto/tls" from the isolated invocation context)
• gofmt -d internal/httputil/tls.go internal/httputil/tls_test.go — clean, no diffs
• Both files are syntactically valid Go

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"

See Network Configuration for more information.

Generated by Repo Assist · 1.2K AIC · ⊞ 45.3K · ◷
_{Comment /repo-assist to run again}

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@851905c06e905bf362a9f6cc54f912e3df747d55

[Copilot]

Pull request overview

This PR resolves a Go compile-time redeclaration failure in internal/httputil by removing the duplicate TLS helper implementation and its duplicate tests, leaving a single authoritative tls.go/tls_test.go pair.

Changes:

• Delete internal/httputil/tls_config.go, which duplicated exported TLS declarations already present in internal/httputil/tls.go.
• Delete internal/httputil/tls_config_test.go, which duplicated test function declarations.
• Preserve test coverage by adding assert.NotNil checks into internal/httputil/tls_test.go.

Show a summary per file

File	Description
internal/httputil/tls_test.go	Adds assert.NotNil assertions so coverage from the removed duplicate test file is retained.
internal/httputil/tls_config.go	Deleted to remove duplicate exported TLS identifiers that caused redeclaration compile errors.
internal/httputil/tls_config_test.go	Deleted to remove duplicate test function declarations that also caused redeclaration errors.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 0