info: initial implementation - #114
Merged
Merged
Conversation
mniestroj
force-pushed
the
device-cert
branch
from
November 14, 2025 21:13
6987d07 to
cb8d0fd
Compare
mniestroj
force-pushed
the
cert-declare-misising-types
branch
from
November 14, 2025 21:14
2f92abd to
9048973
Compare
mniestroj
force-pushed
the
device-cert
branch
5 times, most recently
from
November 14, 2025 21:25
de06b43 to
f5b11db
Compare
mniestroj
force-pushed
the
device-cert
branch
from
November 14, 2025 21:30
f5b11db to
3564a58
Compare
mniestroj
force-pushed
the
device-cert
branch
from
November 17, 2025 17:04
3564a58 to
afec831
Compare
sam-golioth
approved these changes
Nov 18, 2025
sam-golioth
left a comment
Contributor
There was a problem hiding this comment.
Thanks @mniestroj! Just a few minor comments.
Read INFO characteristic as the first action after discovering device. Save information about server and device certificates, i.e. whether they were already provisioned. Reading INFO characteristic replaces reading server cert serial number, since the same information is provided. When device certificate provisioned flag is set, this reduces overhead by about 350ms (with default configuration of pouch device). Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
mniestroj
force-pushed
the
device-cert
branch
from
November 20, 2025 14:52
afec831 to
b2d41ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read INFO characteristic as the first action after discovering device. Save information about server and device certificates, i.e. whether they were already provisioned.
Reading INFO characteristic replaces reading server cert serial number, since the same information is provided.
When device certificate provisioned flag is set, this reduces overhead by about 350ms (with default configuration of pouch device).