Conversation
rerickson1
suggested changes
Aug 27, 2025
rerickson1
suggested changes
Aug 27, 2025
rerickson1
reviewed
Aug 27, 2025
rerickson1
approved these changes
Sep 3, 2025
MarkoPura
marked this pull request as ready for review
October 21, 2025 10:01
Contributor
Author
|
@sam-golioth Tested with bluetooth-gateway tip of main and pouch tip of main |
MarkoPura
force-pushed
the
add_mg100
branch
2 times, most recently
from
October 21, 2025 12:39
dd60df1 to
41c709e
Compare
Signed-off-by: Marko Puric <marko@golioth.io>
Signed-off-by: Marko Puric <marko@golioth.io>
Signed-off-by: Marko Puric <marko@golioth.io>
sam-golioth
approved these changes
Oct 29, 2025
| } | ||
| #endif /* CONFIG_NRF_MODEM */ | ||
|
|
||
| #ifdef CONFIG_MODEM_HL7800 |
Contributor
There was a problem hiding this comment.
I'd prefer if this was included based on something more generic rather than switching on the modem in this file. It could be an existing kconfig symbol or it could be one that we define for the gateway and select in mg100.conf. But, as discussed offline, we're already following this pattern for the Nordic modem, so we can address both items later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MG100 is configured to use the HL7800 driver, but it currently hits the same issue described in Zephyr issue #81672. The fixes from PR: HL7800 driver fixes for TLS and DTLS are not included in NCS v3.0.1 (which the Firmware SDK is based on) and will only be available starting with NCS v3.1.0, so we’ll need to wait until the Firmware SDK is updated to that version.