Use indications for uplink - #93
Merged
Merged
Conversation
Signed-off-by: Sam Friedman <sam@golioth.io>
hasheddan
approved these changes
Sep 29, 2025
| if (err) | ||
| { | ||
| LOG_ERR("BT subscribe request failed: %d", err); | ||
| bt_conn_disconnect(conn, BT_HCI_ERR_REMOTE_USER_TERM_CONN); |
Contributor
There was a problem hiding this comment.
For consistency (can we enforce?):
Suggested change
| bt_conn_disconnect(conn, BT_HCI_ERR_REMOTE_USER_TERM_CONN); | |
| (void) bt_conn_disconnect(conn, BT_HCI_ERR_REMOTE_USER_TERM_CONN); |
| if (err) | ||
| { | ||
| LOG_ERR("BT read request failed: %d", err); | ||
| bt_conn_disconnect(conn, BT_HCI_ERR_REMOTE_USER_TERM_CONN); |
Contributor
There was a problem hiding this comment.
Suggested change
| bt_conn_disconnect(conn, BT_HCI_ERR_REMOTE_USER_TERM_CONN); | |
| (void) bt_conn_disconnect(conn, BT_HCI_ERR_REMOTE_USER_TERM_CONN); |
Signed-off-by: Sam Friedman <sam@golioth.io>
sam-golioth
force-pushed
the
use_indications_for_uplink
branch
from
October 1, 2025 19:33
96ae5d2 to
5cbf853
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a discovery step for CCC descriptors. If the characteristic supports indications, use that, otherwise fall back to reads.