uplink: convert 'flags' to array - #99
Merged
Merged
Conversation
Treat 'flags' as array of bits, so that Coverity does not complain about singleton use with atomic_*_bit() API usage. Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
mniestroj
requested review from
sam-golioth and
trond-snekvik
and removed request for
sam-golioth
October 14, 2025 15:00
sam-golioth
approved these changes
Oct 14, 2025
sam-golioth
left a comment
sam-golioth
left a comment
Contributor
There was a problem hiding this comment.
Thanks @mniestroj! One non-blocking comment.
| struct gateway_uplink *session; | ||
| uint32_t block_idx; | ||
| atomic_t flags; | ||
| atomic_t flags[1]; |
Contributor
There was a problem hiding this comment.
We could also use the ATOMIC_DEFINE() macro here.
Collaborator
Author
There was a problem hiding this comment.
Good suggestion. Not sure we want to do that already, since we will likely end up with less than 10 flags anyway. So I don't want to overcomplicate definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat 'flags' as array of bits, so that Coverity does not complain about
singleton use with
atomic_*_bit()API usage.