r/aws_ssm_parameter: v6.58.0 regression when name starts with / - #49325
Draft
ewbankkit wants to merge 2 commits into
Draft
r/aws_ssm_parameter: v6.58.0 regression when name starts with /#49325ewbankkit wants to merge 2 commits into
v6.58.0 regression when name starts with /#49325ewbankkit wants to merge 2 commits into
Conversation
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
There is a regression for the
aws_ssm_parameterresource between v6.57.1 and v6.58.0 ifnamestarts with/(as is common: https://docs.aws.amazon.com/systems-manager/latest/userguide/sysman-paramstore-hierarchies.html).terraform planafter upgrade reportsUnexpected Identity Changeerrorsterraform planafter create reports that the resource needs replacement as thenameattribute values has changedIf I create via the AWS Console and call the AWS API directly:
New acceptance tests
TestAccSSMParameter_NameStartsWithForwardSlash_v6571runs with v6.57.1 only and verifies thatnameretains the leading/in state, butarnformat does not (which matches the AWS API)TestAccSSMParameter_NameStartsWithForwardSlash_v6580runs with v6.58.0 only and shows that bothnameandarnformat have the leading/removed in state. It also shows the ForceNew behaviorRelations
Relates #49304.
Output from Acceptance Testing