New data source azuread_authentication_strength_policy - #1887
Open
anurag-hashicorp wants to merge 5 commits into
Open
New data source azuread_authentication_strength_policy#1887anurag-hashicorp wants to merge 5 commits into
azuread_authentication_strength_policy#1887anurag-hashicorp wants to merge 5 commits into
Conversation
jackofallops
requested changes
Aug 4, 2026
jackofallops
left a comment
jackofallops
left a comment
Member
There was a problem hiding this comment.
Thanks @anurag-hashicorp - One small thing to take a look at, but otherwise looking good.
…list to avoid missing results Addresses review feedback: ListAuthenticationStrengthPolicies only returns the first page of results, so lookups by display_name could silently miss matches beyond the first page.
jackofallops
requested changes
Aug 6, 2026
jackofallops
left a comment
jackofallops
left a comment
Member
There was a problem hiding this comment.
Hi @anurag-hashicorp - Sorry, I missed a schema problem in the last pass, should be good to merge after that's changed.
Member
|
@anurag-hashicorp - One more thing, do we need to hold this back behind #1881 - so it can have the additional schema items from that PR added here? |
…or allowed_combinations Computed-only attributes should use TypeList rather than TypeSet, per review feedback.
Contributor
Author
That's a fair point and I have updated the description. #1881 should merge first and then this data source needs to be updated and merged second. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1881.
This PR should wait for #1881 to merge first and incorporate the schema changes in the
Read()so that both the data source and resource are in sync.Community Note
Description
Changes to existing Resource / Data Source
Testing
https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_AzureAD_AZUREAD_SERVICE_PUBLIC_POLICIES/704726?buildTab=tests
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azuread_authentication_strength_policy- New data source [New data sourceazuread_authentication_strength_policy#1887]This is a (please select all that apply):
Related Issue(s)
Fixes #1385
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.