Fix #1135: Connect PythonASTAnalyzer to the analysis pipeline#1162
Open
anushkagupta200615-jpg wants to merge 1 commit into
Open
Fix #1135: Connect PythonASTAnalyzer to the analysis pipeline#1162anushkagupta200615-jpg wants to merge 1 commit into
anushkagupta200615-jpg wants to merge 1 commit into
Conversation
This commit modifies ast_analyzer.py to correctly call analyze_python_ast(source) so that the PythonASTAnalyzer's results are actually included in the final issues list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies
backend/app/services/ast_analyzer.pyto correctly callanalyze_python_ast(source)within the mainanalyze()function. Previously, thePythonASTAnalyzerclass was instantiated but never executed, skipping vital checks for mutable default arguments, bareexcept:blocks,eval/execusage, and builtin variable shadowing.By appending the results of
analyze_python_ast(source)to theissueslist, these AST-based checks are now successfully integrated into the analysis pipeline.Related Issue
Fixes #1135
Type of change
Checklist
mainpytest -vand all tests pass (forast_analyzer.py)feat/fix/docs/test: short descriptionScreenshots (if frontend change)
N/A
Test evidence