refactor: replace custom email validation with Pydantic EmailStr #971#1169
Open
bhaveshyab wants to merge 1 commit into
Open
refactor: replace custom email validation with Pydantic EmailStr #971#1169bhaveshyab wants to merge 1 commit into
bhaveshyab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced custom string-splitting and regex-like email verification rules with Pydantic's robust, RFC-compliant native
EmailStrdata type across the schemas (SignupRequest,LoginRequest,SubscribeRequest,SubscribeResponse, andUnsubscribeRequest). This deprecates and deletes manual@field_validator("email")hooks while improving validation accuracy.Related Issue
Fixes #971
Type of change
Checklist
Test evidence
============ 451 passed, 115 warnings in 43.28s ============