Skip to content

fix(ios): retain WKHTTPCookieStore observer so cookie sync works #8520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cybertron01Z wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −1
Open

fix(ios): retain WKHTTPCookieStore observer so cookie sync works #8520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ios/Capacitor/Capacitor/CAPBridgeViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ import Cordova

public fileprivate(set) var webView: WKWebView?

// WKHTTPCookieStore does not retain observers, so we hold a strong reference here
// (else it deallocs immediately and `cookiesDidChange` never fires) plus the store
// it was added to, so the observer can be removed in `deinit` as the docs require.
private var cookieObserver: CapacitorWKCookieObserver?
private weak var cookieObserverStore: WKHTTPCookieStore?

public var isStatusBarVisible = true
public var statusBarStyle: UIStatusBarStyle = .default
public var statusBarAnimation: UIStatusBarAnimation = .fade
Expand All @@ -27,6 +33,12 @@ import Cordova
return false
}()

deinit {
if let cookieObserver = cookieObserver {
cookieObserverStore?.remove(cookieObserver)
}
}

override public final func loadView() {
// load the configuration and set the logging flag
let configDescriptor = instanceDescriptor()
Expand Down Expand Up @@ -118,7 +130,11 @@ import Cordova
*/
open func webViewConfiguration(for instanceConfiguration: InstanceConfiguration) -> WKWebViewConfiguration {
let webViewConfiguration = WKWebViewConfiguration()
webViewConfiguration.websiteDataStore.httpCookieStore.add(CapacitorWKCookieObserver())
let cookieObserver = CapacitorWKCookieObserver()
let cookieStore = webViewConfiguration.websiteDataStore.httpCookieStore
cookieStore.add(cookieObserver)
self.cookieObserver = cookieObserver
self.cookieObserverStore = cookieStore
webViewConfiguration.allowsInlineMediaPlayback = true
webViewConfiguration.suppressesIncrementalRendering = false
webViewConfiguration.allowsAirPlayForMediaPlayback = true
Expand Down