VizieR example (use Param in interface)#20
Open
gilleslandais wants to merge 1 commit into
Open
Conversation
Collaborator
|
On Thu, Jul 02, 2026 at 09:19:55AM -0700, gilleslandais wrote:
This is an example of vizier record which contains several tables.
Param applyed to interface allows to link the Conesearch service
with the table definition
Thanks for that; I think that's a valuable addition, both in terms of
features and in terms of complexity (including mirrorURLs).
One point, though: I've long been pained by the lack of quotes in
VizieR table names. This is a pain that TOPCAT works around emitting
warnings and that will to this day break query generation when using
pyVO (without doing funny guesswork); see also my Malta talk
<https://wiki.ivoa.net/internal/IVOA/InterOpNov2024Apps/volimits.pdf>.
VODataService itself says:
When the table set describes a set of TAP-accessible tables, the
value of a table’s name child must be in a form immediately usable
for use in ADQL or SQL queries. This corresponds to the analogous
requirement for TAP_SCHEMA. This means that all qualifications
(schema, catalogue) must be present, but also that when delimited
identifiers are used as table names on the relational side, the
quotes must be part of name’s value, and the capitalisation used in
the DDL must be preserved.
This means that in the tableset, you have to say
<name>"J/AJ/151/120/table2"</name>
and in consequence in stats:
<option>"J/AJ/151/120/table2"</option>
I can understand that you probably don't want to switch TAPVizieR
immediately (presumably some folks have workarounds for the missing
quotes that will break when they are there). But at least in an
example file for the very standard that mandates the quotes they need
to be there.
Also, if you introduce the example with a brief comment on why it's
there, that'd be great, perhaps something like:
<!-- Noteworthy in this example is the use of stats on the SCS2
TABLE parameter that links the particular service with the table it
queries. While this is a use particular to SCS2, is illustrates
one use of stats with input parameters. -->
or something like this.
|
Collaborator
Author
|
As you can imagine, I am also annoyed with quotes in names (especially for columns). Currently the VizieRTAP service add quotes in both xml output (/tap/tables) and in database tap_schema. Update registry - why not - but carrefully : I'm not sure that adding quotes won't have any issues with clients? The best, would be that VizieR adopts new (and modern) conventions. ...I can't give any response yet! ... but that's a good point! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an example of vizier record which contains several tables.
Param applyed to interface allows to link the Conesearch service with the table definition