Update failing specs#33
Open
ramhoj wants to merge 10 commits into
Open
Conversation
added 10 commits
January 24, 2022 19:37
This commit fixes an issue where all requests would fail due to no method error.
The toggl API is no longer reachable on the www subdomain. This commit updates the URL to match the new documented URL. See https://github.com/toggl/toggl_api_docs for more details.
When CSV data is returned EncodingError is raised. The existing implementation expected Oj::ParseError but EncodeError is raised when a csv response is returned. This commit keeps extends the rescue to also capture EncodeError.
The sort order of users may have changed by the API. This commit sorts the response so that the sort order is deterministic.
The API now returns a guid which we can’t deterministically match against. This commit loosens up the assert some what so that it matches even if there are additional keys.
The API now returns 404 on zombie time entries. This commit updates the assertion to match.
This commit fixes a test that failed due to the time zone being formatted differently.
This commit uses the previously introduced spec helper method to ease asserting against time entries.
The API seems to no longer return a list of request. This commit updates the spec to assert against an empty response body instead.
|
@kanet77 can we get some eyes on this? The gem is pretty broken and is starting to look a bit deserted. If you need some help maintaining, shout! It seems like we're all maintaining our own forks otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses various spec failures and closes: