Skip to content

fix(prevnext): improve button alignment - #5169

Open
iitzIrFan wants to merge 3 commits into
mainfrom
fix/prevnext-button-alignment
Open

fix(prevnext): improve button alignment#5169
iitzIrFan wants to merge 3 commits into
mainfrom
fix/prevnext-button-alignment

Conversation

@iitzIrFan

Copy link
Copy Markdown
Member

fixes: #4194


Preview img:
Screenshot 2026-07-17 at 11 50 34 AM

@iitzIrFan iitzIrFan self-assigned this Jul 17, 2026
@iitzIrFan
iitzIrFan marked this pull request as ready for review July 17, 2026 06:21
@iitzIrFan
iitzIrFan requested a review from elevatebart July 17, 2026 06:26
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

☁️ Cloudflare Worker Preview Deployed!

🔗 https://ks-fix-prevnext-button-alignment-docs.kestra-io.workers.dev
🔗 https://84ec2d9e-docs.kestra-io.workers.dev

## 🔦 Lighthouse Benchmark

Tested: http://localhost:8787 on 2026-07-20 14:53 UTC
Compared against main baseline from 2026-07-20

Scores (0–100, higher is better)

Page Performance Accessibility Best Practices SEO
Home 81 🟢 +28 84 54 85
Pricing 98 92 54 100
Enterprise 98 🟢 +98 83 54 100
Cloud 91 88 54 100
About Us 98 91 54 100
Docs Landing 94 🟢 +11 88 54 92
Contribute to Kestra (simple docs) 97 88 54 92
Flow (full featured docs) 91 90 54 92
Blog Index 75 91 54 100
Blog Post (sample) 88 88 54 100
VS Page (sample) 96 88 54 100
Plugins Landing 93 81 54 92
Plugin Page (sample) 0 🔻 -95 88 54 100
Plugin Debug Page (sample) 96 88 54 100
Plugin Debug Return Page (sample) 93 88 58 100
Blueprints Landing 81 91 54 100
Blueprint Audit Logs CSV Export 63 92 54 100

Core Web Vitals (lower is better)

Page LCP FCP TBT CLS Speed Index
Home 1.36 s 0.86 s 282 ms 🟢 0.000 🟢 1.90 s 🟢
Pricing 1.04 s 0.60 s 32 ms 🟢 0.000 0.73 s
Enterprise 1.16 s 0.61 s 26 ms 0.003 0.75 s
Cloud 2.00 s 0.56 s 27 ms 🟢 0.000 🟢 0.86 s
About Us 1.08 s 0.59 s 21 ms 0.000 0.75 s
Docs Landing 1.20 s 🟢 0.99 s 🔻 117 ms 0.000 0.99 s
Contribute to Kestra (simple docs) 1.18 s 0.59 s 43 ms 🟢 0.000 0.79 s
Flow (full featured docs) 1.22 s 🟢 0.61 s 187 ms 0.000 1.09 s
Blog Index 8.77 s 0.50 s 34 ms 0.001 0.89 s
Blog Post (sample) 2.29 s 0.57 s 53 ms 🔻 0.000 0.74 s
VS Page (sample) 1.19 s 0.65 s 68 ms 🔻 0.064 0.73 s
Plugins Landing 0.96 s 0.58 s 63 ms 0.000 2.33 s
Plugin Page (sample) 0.00 s 🟢 0.00 s 🟢 0 ms 🟢 0.000 🟢 0.00 s 🟢
Plugin Debug Page (sample) 1.00 s 0.53 s 32 ms 🟢 0.001 1.65 s
Plugin Debug Return Page (sample) 1.24 s 🔻 0.63 s 54 ms 0.025 1.98 s
Blueprints Landing 2.37 s 0.82 s 48 ms 🟢 0.005 2.74 s
Blueprint Audit Logs CSV Export 1.29 s 0.76 s 167 ms 0.483 3.74 s
Legend

🟢 improved  ·  🔻 regressed  ·  (blank) no significant change
Score threshold: ±10 pts  ·  Metric threshold: ±30% of baseline

@github-project-automation github-project-automation Bot moved this to To review in Pull Requests Jul 17, 2026
@MilosPaunovic MilosPaunovic added area/frontend Needs frontend code changes kind/external Pull requests raised by community contributors and removed kind/external Pull requests raised by community contributors labels Jul 17, 2026
@elevatebart
elevatebart requested a review from Nico-Kestra July 20, 2026 14:19
@elevatebart

Copy link
Copy Markdown
Contributor

I don't mind the change, this was simply what was specified as design and I liked it.
It set the focus on next and not on previous.

let's move "Forward" 😄

@iitzIrFan

Copy link
Copy Markdown
Member Author

Now it has a bit more symmetry though :) Let's see what Nico thinks from the design perspective.

@Nico-Kestra

Copy link
Copy Markdown
Member
Capture d’écran 2026-07-21 à 09 14 48

don't know, originally it was pretty simple, and 'previous' was way less emphasized. The flow is more like: 'I'm reading something—could the next thing interest me? Probably less so the previous one.' So yeah, right now it's too big, too cluttered, too much info for a module that's just supposed to do previous/next, don't you think?

@iitzIrFan iitzIrFan left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation @Nico-Kestra Should I go ahead and close the PR (and the issue as well), since the current design is intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend Needs frontend code changes

Projects

Status: To review

Development

Successfully merging this pull request may close these issues.

Next and Previous Buttons are misaligned (no text and too much text)

4 participants