frontend: add non-clickable section headers to the sidebar#6108
Open
Soli0222 wants to merge 2 commits into
Open
frontend: add non-clickable section headers to the sidebar#6108Soli0222 wants to merge 2 commits into
Soli0222 wants to merge 2 commits into
Conversation
Signed-off-by: Soli0222 <github@str08.net>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Soli0222 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Soli0222 <github@str08.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for non-clickable sidebar section headers that plugins can register through
registerSidebarEntry.Sidebar entries with
entryType: 'subheader'are rendered as section headers. Existing sidebar entries continue to render as clickable links by default, so existingregisterSidebarEntryusage remains compatible.Related Issue
Fixes #6107
Changes
entryTypefield to sidebar entries.entryType: 'subheader'inSidebarItem.ListSubheaderwhen the sidebar is expanded.Dividerwhen the sidebar is collapsed.sxstyle overrides for subheader entries.registerSidebarEntryso plugins can passentryTypeandsx.Steps to Test
Register a regular sidebar entry without
entryTypeand confirm it still renders as a clickable link.Register a sidebar entry with
entryType: 'subheader'and confirm it renders as a non-clickable section header.Collapse the sidebar and confirm the section header is rendered as a divider instead of text.
Run the focused frontend checks.
Screenshots (if applicable)
Notes for the Reviewer
entryType: 'link'by default.