backend: portforward: Fix context key to match rest of backend#6109
Open
r0hansaxena wants to merge 1 commit into
Open
backend: portforward: Fix context key to match rest of backend#6109r0hansaxena wants to merge 1 commit into
r0hansaxena wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: r0hansaxena The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
I'll address the failing check |
2376aec to
14377f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port forwarding broke in 0.43 with "Unreachable" for some clusters. The port forward handler builds the cluster lookup key differently from the rest of the backend, so in some setups it looks for the cluster under a key that was never stored and fails.
This PR changes the port forward handlers to use the same key logic as the rest of the backend instead of building the key themselves.
Related Issue
Fixes #6069
Steps to Test
I reproduced the issue locally and confirmed the same request fails before the change and succeeds after.
Notes for the Reviewer
The existing port forward tests were updated for the new function signatures.