Skip to content

frontend: PluginSettings: Fix User-installed chip contrast #6110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vtushar06 wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −10
Open

frontend: PluginSettings: Fix User-installed chip contrast #6110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions frontend/src/components/App/PluginSettings/PluginSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

import Box from '@mui/material/Box';
import Button from '@mui/material/Button';
import Chip from '@mui/material/Chip';
import Chip, { ChipProps } from '@mui/material/Chip';
import Link from '@mui/material/Link';
import { useTheme } from '@mui/material/styles';
import { SxProps, Theme, useTheme } from '@mui/material/styles';
import { SwitchProps } from '@mui/material/Switch';
import Switch from '@mui/material/Switch';
import Tooltip from '@mui/material/Tooltip';
Expand Down Expand Up @@ -298,22 +298,39 @@ export function PluginSettingsPure(props: PluginSettingsPureProps) {
header: t('translation|Type'),
accessorFn: (plugin: PluginInfo) => plugin.type || 'unknown',
Cell: ({ row: { original: plugin } }: { row: MRT_Row<PluginInfo> }) => {
const typeLabels: Record<string, { label: string; color: any }> = {
const typeLabels: Record<
string,
{ label: string; color: ChipProps['color']; sx?: SxProps<Theme> }
> = {
development: {
label: t('translation|Development'),
color: 'primary',
},
user: {
label: t('translation|User-installed'),
color: 'info',
// info.main is a light blue whose default white text only
// reaches 3.85:1. Use dark text so the chip meets the WCAG
// AA 4.5:1 minimum (5.44:1 on light, 9.1:1 on dark themes).
sx: (theme: Theme) => ({
backgroundColor: theme.palette.info.main,
color: theme.palette.common.black,
}),
},
shipped: {
label: t('translation|Shipped'),
color: 'default',
},
};
const typeInfo = typeLabels[plugin.type || 'shipped'];
return <Chip label={typeInfo.label} size="small" color={typeInfo.color} />;
return (
<Chip
label={typeInfo.label}
size="small"
color={typeInfo.color}
sx={typeInfo.sx}
/>
);
},
},
{
Expand Down
4 changes: 2 additions & 2 deletions ...nents/App/PluginSettings/__snapshots__/PluginSettings.MigrationScenario.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@
class="MuiTableCell-root MuiTableCell-alignLeft MuiTableCell-sizeMedium css-1qzqemr-MuiTableCell-root"
>
<div
class="MuiChip-root MuiChip-filled MuiChip-sizeSmall MuiChip-colorInfo MuiChip-filledInfo css-1qavl4s-MuiChip-root"
class="MuiChip-root MuiChip-filled MuiChip-sizeSmall MuiChip-colorInfo MuiChip-filledInfo css-17z0rci-MuiChip-root"
>
<span
class="MuiChip-label MuiChip-labelSmall css-wjsjww-MuiChip-label"
Expand Down Expand Up @@ -479,7 +479,7 @@
class="MuiTableCell-root MuiTableCell-alignLeft MuiTableCell-sizeMedium css-1qzqemr-MuiTableCell-root"
>
<div
class="MuiChip-root MuiChip-filled MuiChip-sizeSmall MuiChip-colorInfo MuiChip-filledInfo css-1qavl4s-MuiChip-root"
class="MuiChip-root MuiChip-filled MuiChip-sizeSmall MuiChip-colorInfo MuiChip-filledInfo css-17z0rci-MuiChip-root"
>
<span
class="MuiChip-label MuiChip-labelSmall css-wjsjww-MuiChip-label"
Expand Down
8 changes: 4 additions & 4 deletions ...nents/App/PluginSettings/__snapshots__/PluginSettings.MultipleLocations.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@
class="MuiTableCell-root MuiTableCell-alignLeft MuiTableCell-sizeMedium css-1qzqemr-MuiTableCell-root"
>
<div
class="MuiChip-root MuiChip-filled MuiChip-sizeSmall MuiChip-colorInfo MuiChip-filledInfo css-1qavl4s-MuiChip-root"
class="MuiChip-root MuiChip-filled MuiChip-sizeSmall MuiChip-colorInfo MuiChip-filledInfo css-17z0rci-MuiChip-root"
>
<span
class="MuiChip-label MuiChip-labelSmall css-wjsjww-MuiChip-label"
Expand Down Expand Up @@ -645,7 +645,7 @@
class="MuiTableCell-root MuiTableCell-alignLeft MuiTableCell-sizeMedium css-1qzqemr-MuiTableCell-root"
>
<div
class="MuiChip-root MuiChip-filled MuiChip-sizeSmall MuiChip-colorInfo MuiChip-filledInfo css-1qavl4s-MuiChip-root"
class="MuiChip-root MuiChip-filled MuiChip-sizeSmall MuiChip-colorInfo MuiChip-filledInfo css-17z0rci-MuiChip-root"
>
<span
class="MuiChip-label MuiChip-labelSmall css-wjsjww-MuiChip-label"
Expand Down Expand Up @@ -845,7 +845,7 @@
class="MuiTableCell-root MuiTableCell-alignLeft MuiTableCell-sizeMedium css-1qzqemr-MuiTableCell-root"
>
<div
class="MuiChip-root MuiChip-filled MuiChip-sizeSmall MuiChip-colorInfo MuiChip-filledInfo css-1qavl4s-MuiChip-root"
class="MuiChip-root MuiChip-filled MuiChip-sizeSmall MuiChip-colorInfo MuiChip-filledInfo css-17z0rci-MuiChip-root"
>
<span
class="MuiChip-label MuiChip-labelSmall css-wjsjww-MuiChip-label"
Expand Down Expand Up @@ -1052,7 +1052,7 @@
class="MuiTableCell-root MuiTableCell-alignLeft MuiTableCell-sizeMedium css-1qzqemr-MuiTableCell-root"
>
<div
class="MuiChip-root MuiChip-filled MuiChip-sizeSmall MuiChip-colorInfo MuiChip-filledInfo css-1qavl4s-MuiChip-root"
class="MuiChip-root MuiChip-filled MuiChip-sizeSmall MuiChip-colorInfo MuiChip-filledInfo css-17z0rci-MuiChip-root"
>
<span
class="MuiChip-label MuiChip-labelSmall css-wjsjww-MuiChip-label"
Expand Down
Loading