Skip to content

fix: move sidebar toggle button up to avoid OS taskbar overlap#6124

Closed
VaishnaviBardapure wants to merge 1 commit into
kubernetes-sigs:mainfrom
VaishnaviBardapure:fix-sidebar-toggle-taskbar
Closed

fix: move sidebar toggle button up to avoid OS taskbar overlap#6124
VaishnaviBardapure wants to merge 1 commit into
kubernetes-sigs:mainfrom
VaishnaviBardapure:fix-sidebar-toggle-taskbar

Conversation

@VaishnaviBardapure

Copy link
Copy Markdown

Summary

This PR fixes the sidebar toggle button becoming unclickable when the OS taskbar auto-hides and pops up over the sidebar, by adding a 40px bottom margine to push the toggle controls up from the bottom edge.

Related Issue

Fixes #1287

Changes

  • Added 'marginBottom: '40px' to the Box containing sidebarToggleButton in both the Home sidebar and regular sidebar layouts in Sidebar.tsx
  • Updated storybook snapshots to reflect the new spacing

Steps to Test

  1. Enable Windows taskbar auto-hide (Taskbar settings -> Taskbar behaviors -> Automatically hide the taskbar).
  2. Open Headlamp and let the taskbar pop up (move mouse to bottom of screen or trigger a notification).
  3. Verify the sidebar toggle button is now visible and clickable, no longer behind the taskbar.

Screenshots (if applicable)

  • Before : Screenshot 2026-06-21 141422
  • After:
Screenshot 2026-06-21 141548

Notes for the Reviewer

-This is a minimal CSS fix that adds spacing without changing any sidebar functionality. All existing tests pass with updated snapshots reflecting the new layout.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: VaishnaviBardapure
Once this PR has been reviewed and has the lgtm label, please assign ashu8912 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 21, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: VaishnaviBardapure / name: VaishnaviBardapure (fc5d63c)

@kubernetes-prow kubernetes-prow Bot requested review from illume and vyncent-t June 21, 2026 09:43
@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 21, 2026
@kubernetes-prow

Copy link
Copy Markdown

Welcome @VaishnaviBardapure!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 21, 2026

@skoeva skoeva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closing this - the taskbar overlapping app windows is an os issue, not something we need to work around with hardcoded padding

@skoeva skoeva closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

toggle sidebar button unclickable due to OS taskbar behaviour

2 participants