frontend: localize hardcoded "Lines" and "All" strings in LogsButton#6129
frontend: localize hardcoded "Lines" and "All" strings in LogsButton#6129Adii-45 wants to merge 1 commit into
Conversation
|
Welcome @Adii-45! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Adii-45 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR improves frontend internationalization coverage in the LogsButton UI by replacing two remaining hardcoded English strings in the “lines count” dropdown with existing i18n translation keys.
Changes:
- Localized the “Lines”
InputLabelin the logs line-count selector. - Localized the “All” menu option in the same selector using an existing translation key.
| <InputLabel>{t('translation|Lines')}</InputLabel> | ||
| <Select value={lines} onChange={handleLinesChange}> |
skoeva
left a comment
There was a problem hiding this comment.
could you rebase this against main?
Summary
Localizes two hardcoded English strings ("Lines" and "All") in the LogsButton
lines-count dropdown that were missed when other LogsButton strings were localized.
Related Issue
Fixes #6128
Changes
Lineslabel with the existing translation key.Allmenu item with the existing translation key.Testing
Notes for the Reviewer
Both translation keys (
"All"and"Lines") already exist infrontend/src/i18n/locales/en/translation.json(lines 405 and 665 respectively) so no translation file changes are required. The"All"key is already used by this same component for the Severity dropdown's renderValue.