plugins: Add rollback support for failed plugin updates by skools-here · Pull Request #6179 · kubernetes-sigs/headlamp

skools-here · 2026-06-24T13:13:22Z

Summary

This PR makes plugin updates transactional by introducing a backup-and-rollback mechanism in the plugin update flow.

Previously, PluginManager.update() removed the existing plugin before moving the newly downloaded version into place. If the move operation failed due to filesystem errors, insufficient permissions, or disk space issues, the original plugin was permanently lost. This change ensures that the existing plugin is preserved and automatically restored if the update process fails.

Related Issue

Fixes #6174

Changes

Added backup-and-rollback logic to the plugin update workflow.
Created a temporary backup of the existing plugin before applying updates.
Restored the original plugin automatically when update operations fail.
Added unit tests covering successful updates, rollback behavior, and failure scenarios.
Improved update reliability by preventing plugin loss during failed updates.

… updates

…n updates

skools-here · 2026-06-24T15:06:11Z

ptal @illume

Copilot

Pull request overview

This PR makes plugin updates safer by adding a backup-and-rollback mechanism so an existing plugin isn’t lost if installing the new version fails mid-update.

Changes:

Update flow now renames the existing plugin directory to a .backup directory before moving the new plugin into place, and restores it on failure.
Adds cleanup logic for temporary extraction directories on failure.
Adds Electron unit tests covering successful updates, rollback on move failure, and failures before backup creation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
plugins/pluginctl/src/plugin-management.js	Adds backup/rollback behavior to transactionalize CLI plugin updates.
app/electron/plugin-management.ts	Adds backup/rollback behavior to transactionalize Electron plugin updates.
app/electron/plugin-management.test.ts	Adds unit tests for update success, rollback, and pre-backup failure scenarios.

skools-here · 2026-06-25T11:52:41Z

ptal @illume

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

illume

Thanks for this PR.

The open review comments from Copilot still need attention — can you have a look? Once addressed, please mark them as resolved.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

skools-here · 2026-06-27T12:17:17Z

ptal @illume

illume

Thanks for working on this.

Looks like there are some lint errors in the frontend — cd frontend && npm run lint will show them.

How to fix lint errors

Run cd frontend && npm run lint to see all ESLint errors. Many can be fixed automatically with cd frontend && npm run lint -- --fix. Remaining errors need manual attention.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

illume

Thanks for this PR.

The open review comments from Copilot still need attention — can you have a look? Once addressed, please mark them as resolved.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

+  test('Error propagation when progressCallback is provided', async () => {
+    const errorCallback = jest.fn();
+
+    // install should resolve to undefined when progressCallback is provided, as it catches the error and reports it via callback
+    await expect(
+      PluginManager.install(
+        'https://artifacthub.io/packages/headlamp/headlamp-plugins/non-existent-plugin',
+        tempDir,
+        '',
+        errorCallback
+      )
+    ).resolves.toBeUndefined();
+
+    expect(errorCallback).toHaveBeenCalledWith(
+      expect.objectContaining({
+        type: 'error',
+        message: expect.stringContaining('HTTP error! status: 404'),
+      })
+    );
+  });


+      await PluginManager.install(
+        'https://artifacthub.io/packages/headlamp/headlamp-plugins/headlamp_flux',
+        tempDir,
+        '',
+        mockProgressCallback


+        if (progressCallback) {
+            try {
+              progressCallback({ type: 'success', message: 'Plugin Updated' });
+            }  catch (callbackErr) {
+              console.error('Progress callback failed:', callbackErr);
+            }
+        }


illume

Thanks for working on this.

Would you mind addressing the open Copilot review comments? Please mark each comment as resolved after addressing it.

illume

Thanks for the contribution.

This PR has git conflicts — could you resolve them?

How to resolve conflicts

Rebase or merge the latest main into your branch, resolve the conflicts, and push the updated branch.

kubernetes-prow · 2026-08-05T08:39:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skools-here
Once this PR has been reviewed and has the lgtm label, please assign yolossn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubernetes-prow · 2026-08-05T08:40:00Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

skools-here added 2 commits June 24, 2026 18:35

app: electron: Implement transactional backup and rollback for plugin…

6716b1b

… updates

app: pluginctl: Implement transactional backup and rollback for plugi…

38356b0

…n updates

kubernetes-prow Bot requested a review from kahirokunn June 24, 2026 13:13

kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 24, 2026

kubernetes-prow Bot requested a review from yolossn June 24, 2026 13:13

kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2026

illume requested a review from Copilot June 24, 2026 16:07

Copilot started reviewing on behalf of illume June 24, 2026 16:07 View session

Copilot AI reviewed Jun 24, 2026

View reviewed changes

Comment thread plugins/pluginctl/src/plugin-management.js

Comment thread app/electron/plugin-management.ts

app: Improve error handling while removing directory

9239dcd

illume requested a review from Copilot June 26, 2026 06:26

Copilot started reviewing on behalf of illume June 26, 2026 06:26 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread plugins/pluginctl/src/plugin-management.js

Comment thread app/electron/plugin-management.test.ts Outdated

Comment thread app/electron/plugin-management.test.ts Outdated

app: Force cpsync to fail during move

a219269

illume requested a review from Copilot June 26, 2026 09:05

Copilot started reviewing on behalf of illume June 26, 2026 09:06 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread app/electron/plugin-management.ts

Comment thread app/electron/plugin-management.ts

Comment thread plugins/pluginctl/src/plugin-management.js

Comment thread plugins/pluginctl/src/plugin-management.js

illume requested changes Jun 26, 2026

View reviewed changes

plugins: Improve plugin update reliability

b7439b2

kubernetes-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 26, 2026

illume requested a review from Copilot June 26, 2026 16:49

Copilot started reviewing on behalf of illume June 26, 2026 16:49 View session

Copilot AI reviewed Jun 26, 2026

View reviewed changes

Comment thread plugins/pluginctl/src/plugin-management.js Outdated

Comment thread plugins/pluginctl/src/plugin-management.js

plugins: Fix fetch cancellation and update rollback tests

6acd62e

skools-here requested a review from illume June 26, 2026 18:55

illume requested a review from Copilot June 28, 2026 10:10

skools-here added 2 commits July 5, 2026 17:08

plugins: Avoid duplicate error notification

924bb27

plugins: Delete backup dir conditionally

5cd4999

skools-here force-pushed the fix-plugin-update-rollback branch from 72955b1 to 5cd4999 Compare July 5, 2026 11:38

illume requested a review from Copilot July 5, 2026 12:12

illume requested changes Jul 5, 2026

View reviewed changes

Copilot started reviewing on behalf of illume July 5, 2026 12:13 View session

Copilot AI reviewed Jul 5, 2026

View reviewed changes

Comment thread plugins/pluginctl/src/plugin-management.test.js

illume requested changes Jul 5, 2026

View reviewed changes

plugins: Ensure plugin exists before editing

b6eac40

illume requested a review from Copilot July 6, 2026 12:20

Copilot started reviewing on behalf of illume July 6, 2026 12:21 View session

Copilot AI reviewed Jul 6, 2026

View reviewed changes

Comment thread plugins/pluginctl/src/plugin-management.js

Comment thread app/electron/plugin-management.ts

skools-here added 3 commits July 6, 2026 19:19

plugins: Recover orphaned backup dirs

8088c61

plugins: Add tests for orphaned backup dirs recovery

272133d

plugins: Fix ci failed test

dda9c97

kubernetes-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 6, 2026

illume requested a review from Copilot July 7, 2026 09:21

Copilot started reviewing on behalf of illume July 7, 2026 09:22 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

illume requested changes Jul 8, 2026

View reviewed changes

illume added app kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. plugins testing labels Jul 25, 2026

illume requested changes Aug 5, 2026

View reviewed changes

kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2026

Uh oh!

Conversation

skools-here commented Jun 24, 2026

Summary

Related Issue

Changes

Uh oh!

skools-here commented Jun 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

skools-here commented Jun 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

skools-here commented Jun 27, 2026

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

illume left a comment

Choose a reason for hiding this comment

Uh oh!

kubernetes-prow Bot commented Aug 5, 2026

Uh oh!

kubernetes-prow Bot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone