fix(runtime): curate Codex protocol artifact baseline - #161
Merged
Conversation
Generate the complete upstream protocol in a temporary directory while committing only TypeScript build inputs and the two aggregate JSON Schema snapshots. Enforce matching Codex CLI and SDK versions and reject granular-schema drift. Closes #156
Owner
Author
Code reviewVerdict: COMMENT (non-blocking) This PR narrows the committed Codex App Server baseline to build-required TypeScript plus the two aggregate schemas, while adding temporary generation, CLI/SDK version parity, and focused drift tests. The production risk is low because the runtime contract and generated TypeScript inputs are unchanged. Build, ESLint, Tests, audit, and MCP checks are green. The red Must fixNone. Should fix
Nits
Context gates
Positive notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@openai/codex-sdkWhy
The per-type and per-method JSON Schema files duplicate definitions already present in the aggregate schemas, are not consumed at runtime, and make Codex protocol updates unnecessarily large. This change removes 271 tracked granular schema files and more than 56,000 duplicated lines while preserving every generated TypeScript build input and both aggregate protocol snapshots.
Safety
Testing
npm run ai:validate@aif/runtimetests0.145.0Closes #156