Fixed bug in doRequest causing requests to not be sent when RetryCount set to 0

[ezilber-akamai]

📝 Description

Fixed a bug that caused doRequest to send no requests when the RetryCount is set to 0. New behavior now mimics resty, where at least one request is always sent, with the number of retries (not total requests) dictated by SetRetryCount.

✔️ How to Test

make tet-unit
make test-int

[Copilot]

Pull request overview

Fixes Client.doRequest retry loop semantics so a request is still attempted when RetryCount is set to 0, aligning behavior with “retries after the initial attempt” expectations.

Changes:

• Update doRequest to iterate retryCount + 1 times so retryCount=0 still performs a single request.
• Clarify SetRetryCount documentation to define “retries” vs “attempts”.
• Add a regression unit test for retryCount=0.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
client.go	Adjusts retry loop to ensure at least one attempt; updates retry-count semantics documentation.
client_test.go	Adds a regression test covering the retryCount=0 behavior.

Comments suppressed due to low confidence (1)

client.go:478

• SetRetryCount doc comment has an extra trailing period, and the method currently accepts negative counts which would still result in zero requests (since doRequest ranges over retryCount+1). Consider clamping negatives to 0 so at least one request is always attempted.

// SetRetryCount sets the number of retries after the initial request before aborting. .
func (c *Client) SetRetryCount(count int) *Client {
	c.retryCount = count
	return c
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.