chore(wait): apply review suggestions to exit_test and health_test#1
Open
mdelapenya wants to merge 1 commit into
Conversation
- Switch to package wait_test - Replace hand-written mocks with mockStrategyTarget + typed EXPECT() chains - Use anyContext matcher for context args - Use moby/moby import paths (not docker/docker) - Use typed container state constants - Extract newStateTarget() helper in health_test.go - Replace goroutine+mutex pattern in TestWaitForHealthWithNil with RunAndReturn closure Addresses review feedback on PR testcontainers#3603.
mateenali66
force-pushed
the
feat/issue-2765-generated-mocks-wait
branch
from
728129a to
77c1ac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review feedback from the testcontainers maintainers on PR testcontainers#3603.
Changes
wait/exit_test.goandwait/health_test.gomigrated frompackage waittopackage wait_testmockStrategyTarget(already generated and checked in)EXPECT()chains used throughout — consistent withfile_test.goandlog_test.goanyContextmatcher reused for context arguments (not baremock.Anything)github.com/moby/moby/api/types/containercontainer.State*constants used instead of raw string literalsnewStateTarget(t, state)helper extracted inhealth_test.go, mirroringnewRunningTargetpatternTestWaitForHealthWithNil: goroutine+mutex pattern replaced with aRunAndReturntime-based closureTest results
All 7 tests pass on current main: