Fix magnification of HTML embedded in MathML or TeX.#1530
Open
dpvc wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1530 +/- ##
===========================================
- Coverage 86.70% 86.70% -0.01%
===========================================
Files 340 340
Lines 86264 86273 +9
Branches 3246 4906 +1660
===========================================
+ Hits 74798 74802 +4
+ Misses 11466 11451 -15
- Partials 0 20 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with the keyboard or mouse magnification of expressions that include HTML embedded in the MathML or TeX expressions. The HTML was not being properly enlarged in the magnification window. This is due to the use of
pxfont sizing in the CHTML output, and a pad interaction with the scaling in SVG output.The solution for CHTML is to override the
getFontStyles()method to use a scaling inemunits (in this case, the parent elements already do the relative scaling, so1emkeeps it at that scale). For SVG, settingfont-sizeto initial and leaving thepxvalues seems to do the trick.