Skip to content

[WC-3314] Combobox: mitigate issue with empty string to executeAction() #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r0b1n wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WC-3314] Combobox: mitigate issue with empty string to executeAction() #2305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/pluggableWidgets/combobox-web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

- We fixed an issue where the combobox collapsed to 1px width when placed inside a flex row container with `align-items: center`.

- We fixed an issue where the widget crashed when using the "On filter input change" action with the new string behavior enabled.

## [2.8.1] - 2026-04-30

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/combobox-web/src/hooks/useGetSelector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ function onInputValueChange(
}
if (onChangeFilterInputEvent.canExecute && !onChangeFilterInputEvent.isExecuting) {
onChangeFilterInputEvent.execute({
filterInput: filterValue
filterInput: filterValue || undefined
});
}
}
Expand Down
Loading