-
Notifications
You must be signed in to change notification settings - Fork 422
refactor: anonymized diagnostic-snippet telemetry + embed the deslop engine in @react-doctor/core #912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aidenybai
wants to merge
14
commits into
main
Choose a base branch
from
scrambler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: anonymized diagnostic-snippet telemetry + embed the deslop engine in @react-doctor/core #912
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3cc3fa7
feat(deslop-js): add scramble, an AST-based snippet anonymizer
aidenybai f6dda50
fix(deslop-js): blind private fields, JSX text, and binding type names
aidenybai 42beadb
fix(deslop-js): key placeholder cache by role + name
aidenybai 4773042
fix(deslop-js): bound template-text blanking to the node span
aidenybai 6f645f8
refactor: move scramble from deslop-js public API into react-doctor
aidenybai 8dc5dc9
docs(react-doctor): clarify scramble diagnostic offsets are UTF-16, n…
aidenybai 1b534f3
refactor(react-doctor): trim scramble comments to the load-bearing few
aidenybai a98bccf
refactor(react-doctor): reuse the canonical OxcAstNode name in scramble
aidenybai 0bdc4ee
refactor: dedupe OxcAstNode by reusing deslop-js's canonical helper
aidenybai 42fae4e
feat(react-doctor): emit anonymized diagnostic snippets to telemetry
aidenybai 4f7ec03
refactor: embed the deslop engine in @react-doctor/core; deslop-js/cl…
aidenybai 45e3b46
Merge remote-tracking branch 'origin/main' into scrambler
aidenybai c674127
fix(core): keep deslop analyze() tests POSIX-only on Windows
aidenybai 596c0c7
fix(language-server): declare deslop-js for the dead-code path
aidenybai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "deslop-js": patch | ||
| --- | ||
|
|
||
| Restructure internally: the deslop analysis engine now lives in `@react-doctor/core` (under `src/deslop`, exposed via the `@react-doctor/core/deslop` subpath) and `deslop-js` is a thin facade that re-exports it. `vp pack` still bundles the engine into this package's `dist` (CJS + ESM) alongside the sibling `parse-worker.mjs`, so the published tarball stays self-contained and runtime-dependency-free beyond the existing `oxc-parser`/`oxc-resolver`/`fast-glob`/`minimatch` externals. The public API (`analyze`, `defineConfig`, `isOxcAstNode`, and every exported type) is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "deslop-js": patch | ||
| --- | ||
|
|
||
| Expose the `isOxcAstNode` type guard and its `OxcAstNode` interface from the package entry. These were already internal utilities; publishing them lets consumers walk oxc ASTs without re-declaring the same guard. No runtime behavior changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "react-doctor": patch | ||
| --- | ||
|
|
||
| Ship anonymized diagnostic snippets to telemetry. When Sentry tracing is enabled, each scan now emits a small, deduplicated, capped sample of the structural shapes that rules fire on — identifiers and literals are blinded, only the AST structure is preserved — as child spans of the run trace. No real source, names, paths, or literals leave the machine, and the pass is a no-op when telemetry is off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.